RE: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 controllers

2005-08-26 Thread Venkatesan, Ganesh
: Jeff Garzik [mailto:[EMAIL PROTECTED] >Sent: Thursday, August 25, 2005 9:52 PM >To: Venkatesan, Ganesh >Cc: Chilakala, Mallikarjuna; Ronciak, John; Brandeburg, Jesse; netdev >Subject: Re: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 >controllers > >Venkat

Re: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 controllers

2005-08-25 Thread Jeff Garzik
Venkatesan, Ganesh wrote: Jeff: E1000_osdep.h has a macro msec_delay that does exactly what you've mentioned below (check for the correct context and call msleep). Did you mean that you did not want drivers to have their own msec_delay() macros? I meant: have a human check the context. In thi

RE: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 controllers

2005-08-25 Thread Venkatesan, Ganesh
>Sent: Thursday, August 25, 2005 1:31 PM >To: Chilakala, Mallikarjuna >Cc: netdev >Subject: Re: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 >controllers > >Malli Chilakala wrote: >> -/* Simply wait for 10ms */ >> -msec_delay(10); >

Re: PATCH net-drivers-2.6 1/8] e1000: Support for 82571 and 82572 controllers

2005-08-25 Thread Jeff Garzik
Malli Chilakala wrote: -/* Simply wait for 10ms */ -msec_delay(10); +switch (hw->mac_type) { +default: +msec_delay(10); +break; +case e1000_82571: +case e1000_82572: +while (timeout) { +if (E1000_READ_REG(hw, EEMNGCTL) & cfg_mask) +