Re: NAPI on USB network drivers

2017-01-26 Thread Oliver Hartkopp
On 01/25/2017 09:57 PM, Alexander Duyck wrote: On Wed, Jan 25, 2017 at 5:33 AM, Oliver Hartkopp wrote: You could probably get around the o-o-o problem by enabling RPS for the interface. I have found that it works for me to do that in order to resolve o-o-o frames generated by VMs on virtual in

RE: NAPI on USB network drivers

2017-01-25 Thread Hayes Wang
Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, January 25, 2017 10:13 PM [...] > You also could use napi_complete_done() instead of napi_complete(), as > it allows users to tune the performance vs latency for GRO. > > Looking at this driver, I do not see any limitation on the numb

Re: NAPI on USB network drivers

2017-01-25 Thread Alexander Duyck
On Wed, Jan 25, 2017 at 5:33 AM, Oliver Hartkopp wrote: > On 01/25/2017 10:39 AM, Hayes Wang wrote: >> >> Oliver Neukum [mailto:oneu...@suse.com] >>> >>> Sent: Wednesday, January 25, 2017 5:35 PM >> >> [...] >>> >>> looking at r8152 I noticed that it uses NAPI. I never considered >>> this for the

Re: NAPI on USB network drivers

2017-01-25 Thread David Miller
From: Oliver Neukum Date: Wed, 25 Jan 2017 10:34:41 +0100 > looking at r8152 I noticed that it uses NAPI. I never considered > this for the generic USB networking code as you cannot disable > interrupts for USB. Is it still worth it? What are the benefits? I think it's not a good approach for ge

Re: NAPI on USB network drivers

2017-01-25 Thread Eric Dumazet
On Wed, 2017-01-25 at 09:39 +, Hayes Wang wrote: > Oliver Neukum [mailto:oneu...@suse.com] > > Sent: Wednesday, January 25, 2017 5:35 PM > [...] > > looking at r8152 I noticed that it uses NAPI. I never considered > > this for the generic USB networking code as you cannot disable > > interrupts

Re: NAPI on USB network drivers

2017-01-25 Thread Oliver Hartkopp
On 01/25/2017 10:39 AM, Hayes Wang wrote: Oliver Neukum [mailto:oneu...@suse.com] Sent: Wednesday, January 25, 2017 5:35 PM [...] looking at r8152 I noticed that it uses NAPI. I never considered this for the generic USB networking code as you cannot disable interrupts for USB. Is it still wort

RE: NAPI on USB network drivers

2017-01-25 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] > Sent: Wednesday, January 25, 2017 5:35 PM [...] > looking at r8152 I noticed that it uses NAPI. I never considered > this for the generic USB networking code as you cannot disable > interrupts for USB. Is it still worth it? What are the benefits? You could