RE: AF_XDP design flaws

2019-03-21 Thread Maxim Mikityanskiy
oukan ; Saeed > Mahameed ; Eran Ben Elisha > Subject: Re: AF_XDP design flaws > > On Thu, 7 Mar 2019 at 16:09, Maxim Mikityanskiy > wrote: > > > [...] > > > > > Now, onto Max' concerns, from my perspective: > > > > > > 1. The kerne

Re: AF_XDP design flaws

2019-03-07 Thread Björn Töpel
On Thu, 7 Mar 2019 at 16:09, Maxim Mikityanskiy wrote: > [...] > > > Now, onto Max' concerns, from my perspective: > > > > 1. The kernel spins too much in napi mode. > > Not just too much, it will do it forever if the application simply doesn't > act. > > > Yes, the i40e driver does spin for thro

Re: AF_XDP design flaws

2019-03-07 Thread Alexei Starovoitov
On Thu, Mar 07, 2019 at 03:09:33PM +, Maxim Mikityanskiy wrote: > > What I'm concerned of is a security hole this feature opens to the systems > not using AF_XDP. could you please explain the 'security hole' again because I still don't see one.

RE: AF_XDP design flaws

2019-03-07 Thread Maxim Mikityanskiy
> -Original Message- > From: Björn Töpel > Sent: 5 March, 2019 20:26 > To: Maxim Mikityanskiy > Cc: Jonathan Lemon ; John Fastabend > ; netdev@vger.kernel.org; Björn Töpel > ; Magnus Karlsson ; David > S. Miller ; Tariq Toukan ; Saeed > Mahameed ; Eran Ben El

Re: AF_XDP design flaws

2019-03-05 Thread Björn Töpel
On Thu, 28 Feb 2019 at 11:50, Maxim Mikityanskiy wrote: > [...] Back in the saddle! Sorry for the delay! Ok, let me try to summarize. First, let's go through the current AF_XDP semantics so that we're all on the same page, and then pull Max' suggestions in. Ingress --- The simplified flow

Re: AF_XDP design flaws

2019-02-28 Thread Magnus Karlsson
axim Mikityanskiy ; > >> netdev@vger.kernel.org; Björn > >> Töpel ; Magnus Karlsson > >> ; > >> David S. Miller ; Tariq Toukan > >> ; > >> Saeed Mahameed ; Eran Ben Elisha > >> > >> Subject: Re: AF_XDP design fla

RE: AF_XDP design flaws

2019-02-28 Thread Maxim Mikityanskiy
Maxim Mikityanskiy ; > >> netdev@vger.kernel.org; Björn > >> Töpel ; Magnus Karlsson > >> ; > >> David S. Miller ; Tariq Toukan > >> ; > >> Saeed Mahameed ; Eran Ben Elisha > >> > >> Subject: Re: AF_XDP design flaws > >> > >

Re: AF_XDP design flaws

2019-02-27 Thread Jonathan Lemon
Elisha Subject: Re: AF_XDP design flaws On 2019-02-26 17:41, John Fastabend wrote: On 2/26/19 6:49 AM, Maxim Mikityanskiy wrote: Hi everyone, Hi! It's exciting to see more vendors looking into AF_XDP. ARM was involved early on, and now Mellanox. :-) It's really important that the AF

RE: AF_XDP design flaws

2019-02-27 Thread Maxim Mikityanskiy
> -Original Message- > From: Björn Töpel > Sent: 27 February, 2019 10:09 > To: John Fastabend > Cc: Maxim Mikityanskiy ; netdev@vger.kernel.org; Björn > Töpel ; Magnus Karlsson ; > David S. Miller ; Tariq Toukan ; > Saeed Mahameed ; Eran Ben Elisha > Subje

Re: AF_XDP design flaws

2019-02-27 Thread Björn Töpel
On 2019-02-26 17:41, John Fastabend wrote: > On 2/26/19 6:49 AM, Maxim Mikityanskiy wrote: >> Hi everyone, >> Hi! It's exciting to see more vendors looking into AF_XDP. ARM was involved early on, and now Mellanox. :-) It's really important that the AF_XDP model is a good fit for all drivers/vendor

Re: AF_XDP design flaws

2019-02-26 Thread John Fastabend
On 2/26/19 6:49 AM, Maxim Mikityanskiy wrote: > Hi everyone, > > I would like to discuss some design flaws of AF_XDP socket (XSK) > implementation > in kernel. At the moment I don't see a way to work around them without > changing > the API, so I would like to make sure that I'm not missing anyt