RE: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Tuesday, December 8, 2020 1:43 AM > > On Mon, 7 Dec 2020 20:00:53 + Parav Pandit wrote: > > > > > Each port is a logically separate ingress/egress point of the device. > > > > > > > > > > ? > > > > This may not be true when both physical ports are under bond.

Re: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 20:00:53 + Parav Pandit wrote: > > > > Each port is a logically separate ingress/egress point of the device. > > > > > > > > ? > > > This may not be true when both physical ports are under bond. > > > > Bonding changes forwarding logic, not what points of egress ASIC has

RE: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Monday, December 7, 2020 11:10 PM > > On Mon, 7 Dec 2020 04:46:14 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Sunday, December 6, 2020 1:57 AM > > > > > > On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote: > > > > Added documentation for

Re: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 04:46:14 + Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Sunday, December 6, 2020 1:57 AM > > > > On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote: > > > Added documentation for devlink port and port function related commands. > > > > > > Signed-off-by: Parav

RE: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-06 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Sunday, December 6, 2020 1:57 AM > > On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote: > > Added documentation for devlink port and port function related commands. > > > > Signed-off-by: Parav Pandit > > Reviewed-by: Jiri Pirko > > Reviewed-by: Jacob Keller

Re: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-05 Thread Jakub Kicinski
On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote: > Added documentation for devlink port and port function related commands. > > Signed-off-by: Parav Pandit > Reviewed-by: Jiri Pirko > Reviewed-by: Jacob Keller > + > +Devlink Port > + > + > +``devlink-port`` is a po

Re: [PATCH net-next v4] devlink: Add devlink port documentation

2020-12-03 Thread Randy Dunlap
Hi-- On 12/3/20 10:02 AM, Parav Pandit wrote: > Added documentation for devlink port and port function related commands. > > Signed-off-by: Parav Pandit > Reviewed-by: Jiri Pirko > Reviewed-by: Jacob Keller > --- > Changelog: > v3->v4: > - changed 'exist' to 'exists' > - added 'an' eswitch >