RE: [PATCH net-next] openvswitch: add NSH support

2017-08-08 Thread Yang, Yi Y
sday, August 8, 2017 10:28 PM To: Yang, Yi Y Cc: netdev@vger.kernel.org; d...@openvswitch.org; da...@davemloft.net Subject: Re: [PATCH net-next] openvswitch: add NSH support On Tue, 8 Aug 2017 12:59:40 +0800, Yi Yang wrote: > +struct ovs_key_nsh { > + __u8 flags; > + __u8 mdtype

Re: [PATCH net-next] openvswitch: add NSH support

2017-08-08 Thread Jiri Benc
On Tue, 8 Aug 2017 12:59:40 +0800, Yi Yang wrote: > +struct ovs_key_nsh { > + __u8 flags; > + __u8 mdtype; > + __u8 np; > + __u8 pad; > + __be32 path_hdr; > + __be32 c[4]; "c" is a very poor name. Please rename it to something that expresses what this field contains. Also