RE: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-04-18 Thread Dongseok Yi
On Sat, Apr 17, 2021 at 11:44:35AM +0800, Yunsheng Lin wrote: > > On 2021/1/6 11:32, Dongseok Yi wrote: > > On 2021-01-06 12:07, Willem de Bruijn wrote: > >> > >> On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > >>> > >>> On 2021-01-05 06:03, Willem de Bruijn wrote: > > On Mon, Jan 4

Re: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-04-16 Thread Yunsheng Lin
On 2021/1/6 11:32, Dongseok Yi wrote: > On 2021-01-06 12:07, Willem de Bruijn wrote: >> >> On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: >>> >>> On 2021-01-05 06:03, Willem de Bruijn wrote: On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > skbs in frag_list could be shar

Re: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-06 Thread Willem de Bruijn
On Tue, Jan 5, 2021 at 10:32 PM Dongseok Yi wrote: > > On 2021-01-06 12:07, Willem de Bruijn wrote: > > > > On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > > > > > > On 2021-01-05 06:03, Willem de Bruijn wrote: > > > > > > > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > > > > >

RE: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-05 Thread Dongseok Yi
On 2021-01-06 12:07, Willem de Bruijn wrote: > > On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > > > > On 2021-01-05 06:03, Willem de Bruijn wrote: > > > > > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > > > > > skbs in frag_list could be shared by pskb_expand_head() from BPF.

Re: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-05 Thread Willem de Bruijn
On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote: > > On 2021-01-05 06:03, Willem de Bruijn wrote: > > > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > > > skbs in frag_list could be shared by pskb_expand_head() from BPF. > > > > Can you elaborate on the BPF connection? > > With the

RE: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-05 Thread Dongseok Yi
On 2021-01-05 06:03, Willem de Bruijn wrote: > > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > > > skbs in frag_list could be shared by pskb_expand_head() from BPF. > > Can you elaborate on the BPF connection? With the following registered ptypes, /proc/net # cat ptype Type Device

Re: [PATCH net] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-04 Thread Willem de Bruijn
On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote: > > skbs in frag_list could be shared by pskb_expand_head() from BPF. Can you elaborate on the BPF connection? > While tcpdump, sk_receive_queue of PF_PACKET has the original frag_list. > But the same frag_list is queued to PF_INET (or PF_INET6)