Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-05 Thread Jason Wang
在 2021/4/2 下午7:00, Xuan Zhuo 写道: On Fri, 2 Apr 2021 10:52:12 +0800, Jason Wang wrote: So I wonder something like the following like this help. We know the frag size, that means, if we know there's sufficient tailroom we can use build_skb() without reserving dedicated room for skb_shared_info.

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-01 Thread Jason Wang
在 2021/4/1 下午5:58, Eric Dumazet 写道: On Thu, Apr 1, 2021 at 11:04 AM Xuan Zhuo wrote: On Thu, 1 Apr 2021 15:14:18 +0800, Jason Wang wrote: 在 2021/3/31 下午4:11, Michael S. Tsirkin 写道: On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo wr

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-01 Thread Michael S. Tsirkin
On Wed, Mar 31, 2021 at 10:36:35AM +0200, Eric Dumazet wrote: > On Wed, Mar 31, 2021 at 10:11 AM Michael S. Tsirkin wrote: > > > > On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: > > > On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 13 Jan 2021 08:18

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-01 Thread Michael S. Tsirkin
On Wed, Mar 31, 2021 at 07:30:39PM +0800, Xuan Zhuo wrote: > On Wed, 31 Mar 2021 04:11:12 -0400, Michael S. Tsirkin > wrote: > > On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: > > > On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 13 Jan 2021 08:18:

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-04-01 Thread Jason Wang
在 2021/3/31 下午4:11, Michael S. Tsirkin 写道: On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo wrote: On Wed, 13 Jan 2021 08:18:19 -0800, Eric Dumazet wrote: From: Eric Dumazet Both virtio net and napi_get_frags() allocate skbs with a

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-03-31 Thread Michael S. Tsirkin
On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: > On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo wrote: > > > > On Wed, 13 Jan 2021 08:18:19 -0800, Eric Dumazet > > wrote: > > > From: Eric Dumazet > > > > > > Both virtio net and napi_get_frags() allocate skbs > > > with a very small s

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-01-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 13 Jan 2021 08:18:19 -0800 you wrote: > From: Eric Dumazet > > Both virtio net and napi_get_frags() allocate skbs > with a very small skb->head > > While using page fragments instead of a kmalloc backed skb->head migh

RE: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-01-14 Thread David Laight
From: Eric Dumazet > Sent: 14 January 2021 05:17 > > On Wed, Jan 13, 2021 at 11:23 PM David Laight wrote: > > > > From: Eric Dumazet > > > Sent: 13 January 2021 16:18 > > > > > > From: Eric Dumazet > > > > > > Both virtio net and napi_get_frags() allocate skbs > > > with a very small skb->head >

RE: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-01-13 Thread David Laight
From: Eric Dumazet > Sent: 13 January 2021 16:18 > > From: Eric Dumazet > > Both virtio net and napi_get_frags() allocate skbs > with a very small skb->head > > While using page fragments instead of a kmalloc backed skb->head might give > a small performance improvement in some cases, there is

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-01-13 Thread Michael S. Tsirkin
On Wed, Jan 13, 2021 at 08:18:19AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Both virtio net and napi_get_frags() allocate skbs > with a very small skb->head > > While using page fragments instead of a kmalloc backed skb->head might give > a small performance improvement in some cases,

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

2021-01-13 Thread Alexander Duyck
On Wed, Jan 13, 2021 at 8:20 AM Eric Dumazet wrote: > > From: Eric Dumazet > > Both virtio net and napi_get_frags() allocate skbs > with a very small skb->head > > While using page fragments instead of a kmalloc backed skb->head might give > a small performance improvement in some cases, there is