Re: [PATCH V2] Add flow control to the portmapper

2016-07-24 Thread Leon Romanovsky
On Fri, Jul 22, 2016 at 10:26:01AM -0500, Shiraz Saleem wrote: > On Thu, Jul 21, 2016 at 08:29:42PM +0300, Leon Romanovsky wrote: > > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > > > On Tue, Jul 19, 2016 at

Re: [PATCH V2] Add flow control to the portmapper

2016-07-24 Thread Leon Romanovsky
On Thu, Jul 21, 2016 at 12:42:42PM -0500, Steve Wise wrote: > > > > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > > > > On Tue, Jul 19,

Re: [PATCH V2] Add flow control to the portmapper

2016-07-22 Thread Shiraz Saleem
On Thu, Jul 21, 2016 at 08:29:42PM +0300, Leon Romanovsky wrote: > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > > > On Tue, Jul 19, 2016 at

RE: [PATCH V2] Add flow control to the portmapper

2016-07-21 Thread Steve Wise
> > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > > > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > > > > > > >

Re: [PATCH V2] Add flow control to the portmapper

2016-07-21 Thread Leon Romanovsky
On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > > > > > You are the on

Re: [PATCH V2] Add flow control to the portmapper

2016-07-20 Thread Shiraz Saleem
On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > > > You are the one user of this new inline function. > > > Why don't you directly call to

Re: [PATCH V2] Add flow control to the portmapper

2016-07-19 Thread Leon Romanovsky
On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > You are the one user of this new inline function. > > Why don't you directly call to netlink_unicast() in your ibnl_unicast() > > without messing with widely vi

Re: [PATCH V2] Add flow control to the portmapper

2016-07-19 Thread Shiraz Saleem
On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > You are the one user of this new inline function. > Why don't you directly call to netlink_unicast() in your ibnl_unicast() > without messing with widely visible header file? Since there is a non-blocking version of nlmsg_unicas

Re: [PATCH V2] Add flow control to the portmapper

2016-07-18 Thread Leon Romanovsky
On Mon, Jul 18, 2016 at 02:23:30PM -0500, Shiraz Saleem wrote: > From: Mustafa Ismail > > During connection establishment with a large number of connections, > it is possible that the connection requests might fail. Adding flow > control prevents this failure. Change ibnl unicast to use netlink >