RE: [PATCH 1/4] fs: Implement close-on-fork

2020-05-03 Thread David Laight
From: Karstens, Nate > Sent: 01 May 2020 15:45 > Thanks for the suggestion. I looked into it and noticed that > do_close_on_exec() appears to have some > optimizations as well: > > > set = fdt->close_on_exec[i]; > > if (!set) > > continue; > > If we interleave the close-on-exec and close-on-

Re: [PATCH 1/4] fs: Implement close-on-fork

2020-05-01 Thread Matthew Wilcox
On Fri, May 01, 2020 at 02:45:16PM +, Karstens, Nate wrote: > Others -- I will respond to feedback outside of implementation details in a > separate message. FWIW, I'm opposed to the entire feature. Improving the implementation will not change that.

RE: [PATCH 1/4] fs: Implement close-on-fork

2020-05-01 Thread Karstens, Nate
; Helge Deller ; David S. Miller ; Jakub Kicinski ; linux-fsde...@vger.kernel.org; linux-a...@vger.kernel.org; linux-al...@vger.kernel.org; linux-par...@vger.kernel.org; sparcli...@vger.kernel.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Changli Gao Subject: Re: [PATCH 1/4] f