It is intentional that the code on lines 122 and 124 is the same?
julia
-- Forwarded message --
Date: Thu, 17 Aug 2017 09:18:50 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH]
Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and
Hi mohamedalrshah,
[auto build test ERROR on net/master]
[also build test ERROR on v4.13-rc5 next-20170816]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/mohamedalrshah/Adding-Agile-SD-TCP-modu
Hi mohamedalrshah,
[auto build test ERROR on net/master]
[also build test ERROR on v4.13-rc5 next-20170816]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/mohamedalrshah/Adding-Agile-SD-TCP-modu
On 08/15/2017 10:36 AM, David Miller wrote:
> From: Randy Dunlap
> Date: Tue, 15 Aug 2017 09:41:53 -0700
>
>> On 08/15/2017 06:51 AM, Neal Cardwell wrote:
>>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
>>> wrote:
>>>
+static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_f
From: Randy Dunlap
Date: Tue, 15 Aug 2017 09:41:53 -0700
> On 08/15/2017 06:51 AM, Neal Cardwell wrote:
>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
>> wrote:
>>
>>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
>>> +{
>>> + struct tcp_sock *tp = tcp_sk
On 08/15/2017 06:08 AM, mohamedalrshah wrote:
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 91a2557..474f72c 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -677,6 +677,17 @@ config TCP_CONG_BBR
> bufferbloat, policers, or AQM schemes that do not provide a delay
>
On 08/15/2017 06:51 AM, Neal Cardwell wrote:
> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
> wrote:
>
>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
>> +{
>> + struct tcp_sock *tp = tcp_sk(sk);
>> + struct agilesdtcp *ca = inet_csk_ca(sk);
>> +
On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
wrote:
> This commit implements a new TCP congestion control algorithm, namely
> Agile-SD.
Also, please use a summary line for your patch that is more in keeping
with Linux style, using spaces rather than dashes, and leading with
tcp: or tcp_agile_
On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
wrote:
> +
> +/* Agile-SD Parameters */
> +struct agilesdtcp {
> + u32 loss_cwnd; /* congestion window at last loss.*/
Please rebase your change on top of the latest net-next changes and
update this module to use the latest app
From: mohamedalrshah
> Sent: 02 August 2017 05:44
> Published:
> Alrshah, M.A., Othman, M., Ali, B. and Hanapi, Z.M., 2015. Agile-SD: a
> Linux-based
> TCP congestion control algorithm for supporting high-speed and short-distance
> networks.
> Journal of Network and Computer Applications, 55, pp.
From: mohamedalrshah
Date: Wed, 2 Aug 2017 12:37:01 +0800
> +//#define NS_PROTOCOL "tcp_agilesd.c"
> +//#include "../ns-linux-c.h"
> +//#include "../ns-linux-util.h"
> +//#include
There is no way this submission will be considered seriously with all of
this cruft in it.
Your new module needs
On Tue, 1 Aug 2017 17:50:05 +0800
mohamedalrshah wrote:
> From: Mohamed Alrshah
>
Please add more background on Agile-SD in the email commit message.
> +static struct tcp_congestion_ops agilesdtcp __read_mostly = {
> + .init = agilesdtcp_init,
> + .ssthresh = agilesd
12 matches
Mail list logo
