Re: Qdisc->u32_node - licence to kill

2017-08-09 Thread Jiri Pirko
Wed, Aug 09, 2017 at 02:40:30PM CEST, j...@mojatatu.com wrote: >On 17-08-07 07:21 PM, Cong Wang wrote: >> On Mon, Aug 7, 2017 at 12:54 PM, John Fastabend >> wrote: >> > On 08/07/2017 12:06 PM, Jiri Pirko wrote: >> > > Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >> > > > O

Re: Qdisc->u32_node - licence to kill

2017-08-09 Thread Jamal Hadi Salim
On 17-08-07 07:21 PM, Cong Wang wrote: On Mon, Aug 7, 2017 at 12:54 PM, John Fastabend wrote: On 08/07/2017 12:06 PM, Jiri Pirko wrote: Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: On 08/07/2017 09:41 AM, Jiri Pirko wrote: Hi Jamal/Cong/David/all. = Not correct.

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread Cong Wang
On Mon, Aug 7, 2017 at 12:54 PM, John Fastabend wrote: > On 08/07/2017 12:06 PM, Jiri Pirko wrote: >> Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >>> On 08/07/2017 09:41 AM, Jiri Pirko wrote: Hi Jamal/Cong/David/all. Digging in the u32 code deeper now. I ne

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread John Fastabend
On 08/07/2017 12:06 PM, Jiri Pirko wrote: > Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >> On 08/07/2017 09:41 AM, Jiri Pirko wrote: >>> Hi Jamal/Cong/David/all. >>> >>> Digging in the u32 code deeper now. I need to get rid of tp->q for shared >>> blocks, but I found out a

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread Jiri Pirko
Mon, Aug 07, 2017 at 07:47:14PM CEST, john.fastab...@gmail.com wrote: >On 08/07/2017 09:41 AM, Jiri Pirko wrote: >> Hi Jamal/Cong/David/all. >> >> Digging in the u32 code deeper now. I need to get rid of tp->q for shared >> blocks, but I found out about this: >> >> struct Qdisc { >> .. >

Re: Qdisc->u32_node - licence to kill

2017-08-07 Thread John Fastabend
On 08/07/2017 09:41 AM, Jiri Pirko wrote: > Hi Jamal/Cong/David/all. > > Digging in the u32 code deeper now. I need to get rid of tp->q for shared > blocks, but I found out about this: > > struct Qdisc { > .. > void*u32_node; > .. > }; > > Yeah, ug

Qdisc->u32_node - licence to kill

2017-08-07 Thread Jiri Pirko
Hi Jamal/Cong/David/all. Digging in the u32 code deeper now. I need to get rid of tp->q for shared blocks, but I found out about this: struct Qdisc { .. void*u32_node; .. }; Yeah, ugly. u32 uses it to store some shared data, tp_c. It actually s