Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread akepner
On Mon, 13 Mar 2006, Luiz Fernando Capitulino wrote: BTW Robert, my TODO list for pktgen so far is: * A new command called 'rem_device' to remove one device at a time (currently, we can only remove all devices in one shoot with 'rem_devices_all') This should be very simple to i

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Luiz Fernando Capitulino
On Mon, 13 Mar 2006 14:29:17 +0100 Robert Olsson <[EMAIL PROTECTED]> wrote: | | Luiz Fernando Capitulino writes: | | > Well, I wouldn't say it's _really_ needed. But it really avoids having | > too many thread entries in the pktgen's /proc directory, and as a good | > result, you will not ha

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Robert Olsson
Luiz Fernando Capitulino writes: > Well, I wouldn't say it's _really_ needed. But it really avoids having > too many thread entries in the pktgen's /proc directory, and as a good > result, you will not have pending threads which will never run as well. > > Also note that the patch is triv

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Luiz Fernando Capitulino
Hi Robert, On Mon, 13 Mar 2006 10:44:49 +0100 Robert Olsson <[EMAIL PROTECTED]> wrote: | | Hello! | | Really needed? Well, I wouldn't say it's _really_ needed. But it really avoids having too many thread entries in the pktgen's /proc directory, and as a good result, you will not have pendi

PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Robert Olsson
Hello! Really needed? If so -- Wouldn't a concept of a bitmask to control also which CPU's that runs the threads be more general? Cheers. --ro Luiz Fernando Capitulino writes: > > Currently, pktgen will create one thread for each online CPU in the

PKTGEN: Adds thread limit parameter.

2006-03-12 Thread Luiz Fernando Capitulino
Currently, pktgen will create one thread for each online CPU in the system. That behaivor may be annoying if you're using pktgen in a large SMP system. This patch adds a new module parameter called 'pg_max_threads', which can be set to the maximum number of threads pktgen should create. For exam