Re: PATCH ax25: Don't hold skb lock while doing blocking read

2020-07-26 Thread thomas
On Mon, 13 Jul 2020 22:31:18 +0100, Eric Dumazet said: > Or you could use a smaller change and make this look like net/x25/af_x25.c ? Ah, good point. Here's a revised version, that like x25 releases the lock and reacquires it. Author: Thomas Habets Date: Fri Jun 26 15:23:26 2020 +0100 a

Re: PATCH ax25: Don't hold skb lock while doing blocking read

2020-07-13 Thread Cong Wang
On Thu, Jul 9, 2020 at 12:53 PM Thomas Habets wrote: > > Here's a test program that illustrates the problem: > https://github.com/ThomasHabets/radiostuff/blob/master/ax25/axftp/examples/client_lockcheck.cc > > Before this patch, this hangs, because the read(2) blocks the > write(2). > > I see that

Re: PATCH ax25: Don't hold skb lock while doing blocking read

2020-07-13 Thread Eric Dumazet
patch title has a typo : there is no skb lock. On 7/9/20 12:49 PM, Thomas Habets wrote: > Here's a test program that illustrates the problem: > https://github.com/ThomasHabets/radiostuff/blob/master/ax25/axftp/examples/client_lockcheck.cc > > Before this patch, this hangs, because the read(2) blo

PATCH ax25: Don't hold skb lock while doing blocking read

2020-07-09 Thread Thomas Habets
Here's a test program that illustrates the problem: https://github.com/ThomasHabets/radiostuff/blob/master/ax25/axftp/examples/client_lockcheck.cc Before this patch, this hangs, because the read(2) blocks the write(2). I see that calling skb_recv_datagram without this lock is done in pep_sock_acc