Re: [PATCH take2] Re: Nested VLAN causes recursive locking error

2008-01-10 Thread Jarek Poplawski
On Thu, Jan 10, 2008 at 10:08:16PM +0100, Jarek Poplawski wrote: ... > But still some 'quirks' are possible there: removing and adding > devices 'properly' would often require resetting of many subclasses, ...Hmm, probably they are always removed from/with the children, then no problem! (I know, I

Re: [PATCH take2] Re: Nested VLAN causes recursive locking error

2008-01-10 Thread Jarek Poplawski
On Thu, Jan 10, 2008 at 04:31:22PM +0100, Patrick McHardy wrote: ... > No, this seems fine, thanks. Even better would be a way to get > the last lockdep subclass through lockdep somehow, but I couldn't > find a clean way for this. So I've applied your patch and also > fixed macvlan. As a matter of

Re: [PATCH take2] Re: Nested VLAN causes recursive locking error

2008-01-10 Thread Patrick McHardy
Jarek Poplawski wrote: As a matter of fact I started to doubt it's a real problem: 2 vlan headers in the row - is it working? Yes, apparently some people are using this. Anyway, as Patrick pointed, the previous patch was a bit buggy, and deeper nesting needs a little more (if it's can work to

[PATCH take2] Re: Nested VLAN causes recursive locking error

2008-01-02 Thread Jarek Poplawski
Benny Amorsen wrote, On 01/02/2008 05:40 PM: ... > The box that shows the problem is "almost-production", so it doesn't > have a build system. Is there a chance you could get the patch into > Rawhide or some other testing repository? It takes forever and a lot > of disk space to rebuild a kernel RP

Re: [PATCH] Re: Nested VLAN causes recursive locking error

2008-01-02 Thread Benny Amorsen
Jarek Poplawski <[EMAIL PROTECTED]> writes: > Subject: [PATCH] nested VLAN: fix lockdep's recursive locking warning > > Allow vlans nesting other vlans without lockdep's warnings (max. 8 levels). > > Reported-by: Benny Amorsen > Tested-by: Benny Amorsen (?) NEEDS TESTING! > > Signed-off-by: J

Re: [PATCH] Re: Nested VLAN causes recursive locking error

2007-12-31 Thread Jarek Poplawski
On Mon, Dec 31, 2007 at 06:45:55PM +0100, Jarek Poplawski wrote: > On Mon, Dec 31, 2007 at 04:04:17PM +0100, Patrick McHardy wrote: ... > > That will increment the subclass globally, but it should actually just > > use real_dev->subclass + 1. [...] ... > to two subclasses - any nested vlan gets sec

Re: [PATCH] Re: Nested VLAN causes recursive locking error

2007-12-31 Thread Jarek Poplawski
On Mon, Dec 31, 2007 at 06:45:55PM +0100, Jarek Poplawski wrote: > Patric, [...] OOPS... Sorry Patrick! Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Re: Nested VLAN causes recursive locking error

2007-12-31 Thread Jarek Poplawski
On Mon, Dec 31, 2007 at 04:04:17PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: >> diff -Nurp linux-2.6.24-rc5-/net/8021q/vlan.c >> linux-2.6.24-rc5+/net/8021q/vlan.c >> --- linux-2.6.24-rc5-/net/8021q/vlan.c 2007-12-17 13:29:19.0 >> +0100 >> +++ linux-2.6.24-rc5+/net/8021

Re: [PATCH] Re: Nested VLAN causes recursive locking error

2007-12-31 Thread Patrick McHardy
Jarek Poplawski wrote: diff -Nurp linux-2.6.24-rc5-/net/8021q/vlan.c linux-2.6.24-rc5+/net/8021q/vlan.c --- linux-2.6.24-rc5-/net/8021q/vlan.c 2007-12-17 13:29:19.0 +0100 +++ linux-2.6.24-rc5+/net/8021q/vlan.c 2007-12-20 14:21:02.0 +0100 @@ -307,12 +307,15 @@ int unregister_vlan

[PATCH] Re: Nested VLAN causes recursive locking error

2007-12-20 Thread Jarek Poplawski
On 19-12-2007 00:03, Chuck Ebbert wrote: > From: > https://bugzilla.redhat.com/show_bug.cgi?id=426164 > > > kernel version is 2.6.24-0.107.rc5.git3.fc9 > > From boot log on serial console: > (full log attached) > > Added VLAN with VID == 2 to IF -:eth0.1568:- > > ==

Nested VLAN causes recursive locking error

2007-12-18 Thread Chuck Ebbert
From: https://bugzilla.redhat.com/show_bug.cgi?id=426164 kernel version is 2.6.24-0.107.rc5.git3.fc9 >From boot log on serial console: (full log attached) Added VLAN with VID == 2 to IF -:eth0.1568:- = [ INFO: possible recursive locking detected ] 2.