RE: Misaligned IPv6 addresses is SCTP socket options.

2020-07-21 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 21 July 2020 03:55 > > On Mon, Jul 20, 2020 at 03:50:16PM +, David Laight wrote: > > Several of the structures in linux/uapi/linux/sctp.h are > > marked __attribute__((packed, aligned(4))). > > I don't think we can change that by now. It's bad, yes, but i

Re: Misaligned IPv6 addresses is SCTP socket options.

2020-07-20 Thread Marcelo Ricardo Leitner
On Mon, Jul 20, 2020 at 03:50:16PM +, David Laight wrote: > Several of the structures in linux/uapi/linux/sctp.h are > marked __attribute__((packed, aligned(4))). I don't think we can change that by now. It's bad, yes, but it's exposed and, well, for a long time (since 2005). > > I believe t

Misaligned IPv6 addresses is SCTP socket options.

2020-07-20 Thread David Laight
Several of the structures in linux/uapi/linux/sctp.h are marked __attribute__((packed, aligned(4))). I believe this was done so that the UAPI structure was the same on both 32 and 64bit systems. The 'natural' alignment is that of 'u64' - so would differ between 32 and 64 bit x86 cpus. There are t