id Miller
Cc: Ananda Raju; netdev@vger.kernel.org
Subject: Re: LRO fix needed
On Thu, Aug 31, 2006 at 04:42:27PM -0700, David Miller wrote:
>
> So could you please make the S2io driver LRO path
> set skb_shared_info(skb)->gso_size appropriately?
> Probably the easiest is to use the length of
On Fri, Sep 01, 2006 at 09:43:47AM +1000, herbert wrote:
>
> It might be better to set it to the biggest frag you see rather
> than the first.
I've coded it up.
BTW Ananda, what hardware assistance do your chips currently provide
for LRO? What are the timeouts used before it gives up on aggregat
On Thu, Aug 31, 2006 at 04:42:27PM -0700, David Miller wrote:
>
> So could you please make the S2io driver LRO path
> set skb_shared_info(skb)->gso_size appropriately?
> Probably the easiest is to use the length of the
> first frag of a multiple frag LRO sequence.
It might be better to set it to
Ananda, Herbert Xu recently found a problem in the TCP stack
input path for LRO capable receive paths.
The issue is that the receive MSS estimator in
tcp_measure_rcv_mss() uses skb->len for the MSS
estimation. This is wrong for LRO frames.
Herbert noticed this using Xen which pused TSO frames
o
