Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 7:49 PM, Jason Gunthorpe wrote: > On Wed, Feb 14, 2018 at 10:35:55AM -0500, Sowmini Varadhan wrote: >> On (02/14/18 16:28), Dmitry Vyukov wrote: >> > syzbot is probably not seeing this problem. However if you don't add >> > the Reported-by tag to commit, nor provide syz fix

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Jason Gunthorpe
On Wed, Feb 14, 2018 at 10:35:55AM -0500, Sowmini Varadhan wrote: > On (02/14/18 16:28), Dmitry Vyukov wrote: > > syzbot is probably not seeing this problem. However if you don't add > > the Reported-by tag to commit, nor provide syz fix tag, it will > > consider it as "open". One consequence of th

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Joe Perches
On Wed, 2018-02-14 at 18:16 +0100, Dmitry Vyukov wrote: > On Wed, Feb 14, 2018 at 6:02 PM, Joe Perches wrote: > > On Wed, 2018-02-14 at 16:55 +0100, Dmitry Vyukov wrote: > > > On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan > > > wrote: > > > > btw, checkpatch.pl complains about the syzbot*@sy

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 6:02 PM, Joe Perches wrote: > On Wed, 2018-02-14 at 16:55 +0100, Dmitry Vyukov wrote: >> On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan >> wrote: >> > btw, checkpatch.pl complains about the syzbot*@syzkaller.appspotmail.com >> > addresses as "Unrecognized email address

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Joe Perches
On Wed, 2018-02-14 at 16:55 +0100, Dmitry Vyukov wrote: > On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan > wrote: > > btw, checkpatch.pl complains about the syzbot*@syzkaller.appspotmail.com > > addresses as "Unrecognized email address", we should fix that > > error from checkpatch at some poi

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan wrote: > On (02/14/18 16:28), Dmitry Vyukov wrote: >> syzbot is probably not seeing this problem. However if you don't add >> the Reported-by tag to commit, nor provide syz fix tag, it will >> consider it as "open". One consequence of this is that

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Sowmini Varadhan
On (02/14/18 16:28), Dmitry Vyukov wrote: > syzbot is probably not seeing this problem. However if you don't add > the Reported-by tag to commit, nor provide syz fix tag, it will > consider it as "open". One consequence of this is that it is still on > our radars. Another consequence is that syzbot

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Wed, Feb 14, 2018 at 4:21 PM, Sowmini Varadhan wrote: > On (02/14/18 16:11), Dmitry Vyukov wrote: >> >> Hi Sowmini, >> >> Was this ever fixed? What's the fix? This still hangs as open. Please >> provide "syz fix" tag. > > Are you still seeing this problem? > > I had expected that the changes ar

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Sowmini Varadhan
On (02/14/18 16:11), Dmitry Vyukov wrote: > > Hi Sowmini, > > Was this ever fixed? What's the fix? This still hangs as open. Please > provide "syz fix" tag. Are you still seeing this problem? I had expected that the changes around rds_destroy_pending - see commit ebeeb1ad9b8a - would have taken

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-02-14 Thread Dmitry Vyukov
On Fri, Jan 12, 2018 at 7:30 PM, Sowmini Varadhan wrote: > On (01/11/18 21:29), syzbot wrote: >> == >> BUG: KASAN: use-after-free in rds_tcp_tune+0x491/0x520 net/rds/tcp.c:397 >> Read of size 4 at addr 8801cd5f6c58 by task kworker

Re: KASAN: use-after-free Read in rds_tcp_tune

2018-01-12 Thread Sowmini Varadhan
On (01/11/18 21:29), syzbot wrote: > == > BUG: KASAN: use-after-free in rds_tcp_tune+0x491/0x520 net/rds/tcp.c:397 > Read of size 4 at addr 8801cd5f6c58 by task kworker/u4:4/4954 Just had an offline discussion with santosh around