Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Martin Lau
On Wed, May 15, 2019 at 11:31:44AM -0700, Wei Wang wrote: > On Wed, May 15, 2019 at 11:06 AM Martin Lau wrote: > > > > On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > > > I think the bug is because when creating exceptions, src_addr is not > > > always set even though fib6_info is in t

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Wei Wang
On Wed, May 15, 2019 at 11:06 AM Martin Lau wrote: > > On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > > I think the bug is because when creating exceptions, src_addr is not > > always set even though fib6_info is in the subtree. (because of > > rt6_is_gw_or_nonexthop() check) > > Howe

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Martin Lau
On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > I think the bug is because when creating exceptions, src_addr is not > always set even though fib6_info is in the subtree. (because of > rt6_is_gw_or_nonexthop() check) > However, when looking up for exceptions, we always set src_addr to t

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread David Ahern
On 5/14/19 1:33 PM, Wei Wang wrote: > I think the bug is because when creating exceptions, src_addr is not > always set even though fib6_info is in the subtree. (because of > rt6_is_gw_or_nonexthop() check) > However, when looking up for exceptions, we always set src_addr to the > passed in flow->s

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-14 Thread Wei Wang
I think the bug is because when creating exceptions, src_addr is not always set even though fib6_info is in the subtree. (because of rt6_is_gw_or_nonexthop() check) However, when looking up for exceptions, we always set src_addr to the passed in flow->src_addr if fib6_info is in the subtree. That c

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-14 Thread Stefano Brivio
On Mon, 13 May 2019 23:12:31 -0700 Wei Wang wrote: > Thanks Mikael for reporting this issue. And thanks David for the bisection. > Let me spend some time to reproduce it and see what is going on. Mikael, by the way, once this is sorted out, it would be nice if you could add your test as a case i

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-13 Thread Wei Wang
Thanks Mikael for reporting this issue. And thanks David for the bisection. Let me spend some time to reproduce it and see what is going on. From: David Ahern Date: Mon, May 13, 2019 at 8:35 PM To: Mikael Magnusson, , Martin KaFai Lau, Wei Wang > On 5/13/19 1:22 PM, Mikael Magnusson wrote: > > H

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-13 Thread David Ahern
On 5/13/19 1:22 PM, Mikael Magnusson wrote: > Hello list, > > I think I have found a regression in 4.15+ kernels. IPv6 PMTU discovery > doesn't seem to work with source-specific routing (AKA source-address > dependent routing, SADR). > > I made a test script (see attachment). It sets up a test en

IPv6 PMTU discovery fails with source-specific routing

2019-05-13 Thread Mikael Magnusson
Hello list, I think I have found a regression in 4.15+ kernels. IPv6 PMTU discovery doesn't seem to work with source-specific routing (AKA source-address dependent routing, SADR). I made a test script (see attachment). It sets up a test environment with three network namespaces (a, b and c)