Re: [PATCH RFC]rfkill - Hardware button support for Wireless cards

2006-07-19 Thread Ivo Van Doorn
Hi, > I have been quite busy lately, hence the reason for this late continuance > of the Hardware button support for Wireless cards discussion. > I have CC'ed the people who discussed this in earlier threads. no problem. Look good, just one thing I'm missing: > +

Re: [PATCH RFC]rfkill - Hardware button support for Wireless cards

2006-07-10 Thread Stefan Rompf
Am Sonntag, 9. Juli 2006 17:49 schrieb Ivo Van Doorn: > I have been quite busy lately, hence the reason for this late continuance > of the Hardware button support for Wireless cards discussion. > I have CC'ed the people who discussed this in earlier threads. no problem. Look good,

[PATCH RFC]rfkill - Hardware button support for Wireless cards

2006-07-09 Thread Ivo Van Doorn
Hi, I have been quite busy lately, hence the reason for this late continuance of the Hardware button support for Wireless cards discussion. I have CC'ed the people who discussed this in earlier threads. With the suggestions made by Vojtech Pavlik I have created the rfkill driver, for wh

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Ivo van Doorn
> > So basicly 1 input device for every single wireless driver that implements > > the RF-Kill button? > > Yes. > > > Is there any particular reason for not using 1 input device shared by all? > > Yes. > > In the unlikely case where there are two devices which implement a > rfkill button in the

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Vojtech Pavlik
On Fri, Jun 23, 2006 at 08:51:33PM +0200, Ivo van Doorn wrote: > > > This is of course not possible for all hardware, but it gives the most > > > flexibility while keeping the possibility to switch of the radio without > > > userspace support. > > > > Let me elaborate a little bit on the possibl

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Ivo van Doorn
On Thursday 22 June 2006 17:55, Jiri Benc wrote: > On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > > With this approach more buttons can be registered, > > it includes the optional field to report an update of the key status > > to the driver that registered it, and it supports for non-p

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Ivo van Doorn
Hi, > > On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > > > With this approach more buttons can be registered, > > > it includes the optional field to report an update of the key status > > > to the driver that registered it, and it supports for non-polling keys. > > > > I think this i

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-23 Thread Vojtech Pavlik
On Thu, Jun 22, 2006 at 05:55:46PM +0200, Jiri Benc wrote: > On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > > With this approach more buttons can be registered, > > it includes the optional field to report an update of the key status > > to the driver that registered it, and it support

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-22 Thread Jiri Benc
On Sat, 17 Jun 2006 17:05:55 +0200, Ivo van Doorn wrote: > With this approach more buttons can be registered, > it includes the optional field to report an update of the key status > to the driver that registered it, and it supports for non-polling keys. I think this is not specific to networking

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-17 Thread Ivo van Doorn
> > Except for the bluetooth radio key (which should be supported by the > > radiobtn interface as well) the other buttons have support through already > > excisting input devices if I am correct. > > You are wrong for quite a bunch of laptop models. That's why I pointed you to > the wistron_btns

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-04 Thread Ivo van Doorn
On Sunday 4 June 2006 12:14, Stefan Rompf wrote: > Am Sonntag 04 Juni 2006 10:02 schrieb Ivo van Doorn: > > > Except for the bluetooth radio key (which should be supported by the > > radiobtn interface as well) the other buttons have support through already > > excisting input devices if I am corr

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-04 Thread Stefan Rompf
Am Sonntag 04 Juni 2006 10:02 schrieb Ivo van Doorn: > Except for the bluetooth radio key (which should be supported by the > radiobtn interface as well) the other buttons have support through already > excisting input devices if I am correct. You are wrong for quite a bunch of laptop models. Tha

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-04 Thread Ivo van Doorn
On Saturday 3 June 2006 10:45, Stefan Rompf wrote: > Am Freitag 02 Juni 2006 16:30 schrieb Ivo van Doorn: > > > > Or actually, I don't think the radiobtn/ won't be actually needed as > > > prefix. The name passed to the radiobtn driver by the driver should be > > > sufficient. > > > > Updated vers

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-03 Thread Stefan Rompf
Am Freitag 02 Juni 2006 16:30 schrieb Ivo van Doorn: > > Or actually, I don't think the radiobtn/ won't be actually needed as > > prefix. The name passed to the radiobtn driver by the driver should be > > sufficient. > > Updated version, > > Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> I don't

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-06-02 Thread Ivo van Doorn
> > > The first parameter of strcat() must be big enough to contain the whole > > > string. > > > > Will replace it with > > sprintf(wrqu->name, "radiobtn/", radiobtn->dev_name); > > Or actually, I don't think the radiobtn/ won't be actually needed as prefix. > The name passed to the radiobtn dri

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-05-31 Thread Ivo van Doorn
On Wednesday 31 May 2006 19:31, Ivo van Doorn wrote: > On Tuesday 30 May 2006 23:43, Francois Romieu wrote: > > Ivo van Doorn <[EMAIL PROTECTED]> : > > [...] > > > diff --git a/drivers/input/misc/radiobtn.c b/drivers/input/misc/radiobtn.c > > > new file mode 100644 > > > index 000..8d3b84a > >

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-05-31 Thread Ivo van Doorn
On Tuesday 30 May 2006 23:43, Francois Romieu wrote: > Ivo van Doorn <[EMAIL PROTECTED]> : > [...] > > diff --git a/drivers/input/misc/radiobtn.c b/drivers/input/misc/radiobtn.c > > new file mode 100644 > > index 000..8d3b84a > > --- /dev/null > > +++ b/drivers/input/misc/radiobtn.c > [...] > >

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-05-30 Thread Francois Romieu
Ivo van Doorn <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/input/misc/radiobtn.c b/drivers/input/misc/radiobtn.c > new file mode 100644 > index 000..8d3b84a > --- /dev/null > +++ b/drivers/input/misc/radiobtn.c [...] > +void radiobtn_poll(unsigned long data) static ? [...] > +int radiob

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-05-29 Thread Ivo van Doorn
Hi, I made a small update on this patch, only a small compile fix and small bugfix. The thing I would like to know now, is if the current approach is the desired situation. - Should only 1 input device be created, or multiple devices? - Should instead of KEY_RADIO new keys be created (KEY_RADIO

[RFC PATCH 2/2] Hardware button support for Wireless cards: rt2x00

2006-05-25 Thread Ivo van Doorn
Use radiobtn interface for radio hardware button support in rt2x00 Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -uprN wireless-dev/drivers/net/wireless/d80211/rt2x00/Kconfig wireless-dev-radiobtn/drivers/net/wireless/d80211/rt2x00/Kconfig --- wireless-dev/drivers/net/wireless/d80211/rt2

[RFC PATCH 0/2] Hardware button support for Wireless cards

2006-05-25 Thread Ivo van Doorn
Hi, As discussed previously on this list hardware button support for wireless cards and Bluetooth devices could use a seperate generalized driver. I have made a first attempt to do this with the suggestions from the discussion. This means that in all cases the hardware will be requested to

[RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-05-25 Thread Ivo van Doorn
Add radiobtn driver. This driver creates an iput device for each registered button and will poll the device frequently to check the latest status of the button. Once the status has changed it will try to enable or disable the radio and send an event to the input device. Signed-off-by: Ivo van Door

RE: Hardware button support for Wireless cards

2006-05-15 Thread Mark Wallis
On Tue, May 16, 2006, Jouni Malinen wrote: > Some hardware designs disable the radio in hardware, some > don't.. In other words, the behavior would not be consistent > between hardware designs unless the radio would be disabled > unconditionally in software-processed case. I would like to > be

Re: Hardware button support for Wireless cards

2006-05-15 Thread Ivo van Doorn
On Monday 15 May 2006 21:46, Jason Lunz wrote: > On Mon, May 15, 2006 at 03:12:50PM -0400, Dan Williams wrote: > > When those bits get set in the register, is the radio already disabled? > > ie, for the bcm43xx chip, is it really force-disabled by the button, or > > does the driver have some contro

Re: Hardware button support for Wireless cards

2006-05-15 Thread John W. Linville
On Mon, May 15, 2006 at 03:27:54PM +, Jason Lunz wrote: > So if there's any desire for consistency of wireless button support, > then I think the software-controlled ones should always shut off the > radio, and optionally inform userspace or the wireless stack using some > event mechanism. FW

Re: Hardware button support for Wireless cards

2006-05-15 Thread Jason Lunz
On Mon, May 15, 2006 at 03:12:50PM -0400, Dan Williams wrote: > When those bits get set in the register, is the radio already disabled? > ie, for the bcm43xx chip, is it really force-disabled by the button, or > does the driver have some control? I assume it disables the radio without any help fro

Re: Hardware button support for Wireless cards

2006-05-15 Thread Michael Buesch
On Monday 15 May 2006 21:12, you wrote: > > There are registers on the bcm43xx chip (0x158 and 0x49A) that indicate > > some "Radio is hardware-disabled" state. We currently don't use that flag > > correctly in the driver. Could you please assist me on testing if your > > switch > > actually toggl

Re: Hardware button support for Wireless cards

2006-05-15 Thread Dan Williams
On Mon, 2006-05-15 at 18:01 +0200, Michael Buesch wrote: > On Monday 15 May 2006 17:27, you wrote: > > [EMAIL PROTECTED] said: > > > Some people are saying that instead of throwing and ACPI event we should > > > be > > > either use hotplug or internally just disable the radio and somehow inform >

Re: Hardware button support for Wireless cards

2006-05-15 Thread Jouni Malinen
On Mon, May 15, 2006 at 05:12:20PM +0200, Ivo van Doorn wrote: > Well I would think it is cleaner to inform userspace that the button is > pressed > and let userspace sort out what exactly should happen. > But I doubt it will be a good idea when the driver is sending and event _and_ > disabled th

Re: Hardware button support for Wireless cards

2006-05-15 Thread David Zeuthen
On Mon, 2006-05-15 at 10:37 -0400, Dan Williams wrote: > Ideally, here's what would happen: the driver/card/whatever generates > an ACPI event, which is noticed by HAL. HAL sets a property on the > _exact_ device which the event is for, and propagates the signal out > over dbus. Any interested a

Re: Hardware button support for Wireless cards

2006-05-15 Thread Michael Buesch
On Monday 15 May 2006 17:27, you wrote: > [EMAIL PROTECTED] said: > > Some people are saying that instead of throwing and ACPI event we should be > > either use hotplug or internally just disable the radio and somehow inform > > the dscape stack that the radio has been disabled. > > > > What are pe

Re: Hardware button support for Wireless cards

2006-05-15 Thread Jason Lunz
[EMAIL PROTECTED] said: > Some people are saying that instead of throwing and ACPI event we should be > either use hotplug or internally just disable the radio and somehow inform > the dscape stack that the radio has been disabled. > > What are peoples thoughts here, should we > > A. be handling t

Re: Hardware button support for Wireless cards

2006-05-15 Thread Ivo van Doorn
On Monday 15 May 2006 16:37, Dan Williams wrote: > On Mon, 2006-05-15 at 22:57 +1000, Mark Wallis wrote: > > Hi everyone, > > > > Currently, in our rt2x00 (using the devicescape stack) we are firing off an > > ACPI event so that the hardware button can be handled in userspace. This > > allows the

Re: Hardware button support for Wireless cards

2006-05-15 Thread Dan Williams
On Mon, 2006-05-15 at 22:57 +1000, Mark Wallis wrote: > Hi everyone, > > Currently, in our rt2x00 (using the devicescape stack) we are firing off an > ACPI event so that the hardware button can be handled in userspace. This > allows the user to basically do whatever they want when this button is >

Re: Hardware button support for Wireless cards

2006-05-15 Thread Sergey Vlasov
On Mon, 15 May 2006 22:57:12 +1000 Mark Wallis wrote: > What are peoples thoughts here, should we > > A. be handling this within our drivers and doing "what the user expects" and > disabling the hardware radio, or > > B. should we be firing an ACPI event and getting the distro's to add scripts

Re: Hardware button support for Wireless cards

2006-05-15 Thread Ivo van Doorn
On Monday 15 May 2006 15:25, Jiri Benc wrote: > On Mon, 15 May 2006 22:57:12 +1000, Mark Wallis wrote: > > Currently, in our rt2x00 (using the devicescape stack) we are firing off an > > ACPI event so that the hardware button can be handled in userspace. This > > allows the user to basically do wha

Re: Hardware button support for Wireless cards

2006-05-15 Thread Jiri Benc
On Mon, 15 May 2006 22:57:12 +1000, Mark Wallis wrote: > Currently, in our rt2x00 (using the devicescape stack) we are firing off an > ACPI event so that the hardware button can be handled in userspace. This > allows the user to basically do whatever they want when this button is > pressed - includ

Hardware button support for Wireless cards

2006-05-15 Thread Mark Wallis
Hi everyone, During our development of the rt2x00 wireless driver we have come across an interesting issue that we want to get comment on from the netdev-community. Some laptops with our Ralink cards build-in also include a hardware button that is meant to enable/disable the wireless card. We are