Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread Steve Dodd
On 22 August 2018 at 05:24, David Miller wrote: > From: Jian-Hong Pan >> [ 56.462464] r8169 :02:00.0: MSI-X entry: context resume: >> > ... >> uh! The MSI-X entry seems missed after resume on this laptop! > > Yeah, having all of the MSI-X entry values

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread Heiner Kallweit
On 22.08.2018 06:24, David Miller wrote: > From: Jian-Hong Pan > Date: Wed, 22 Aug 2018 11:01:02 +0800 > > ... >> [ 56.462464] r8169 :02:00.0: MSI-X entry: context resume: >> > ... >> uh! The MSI-X entry seems missed after resume on this laptop! > > Y

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread David Miller
From: Jian-Hong Pan Date: Wed, 22 Aug 2018 11:01:02 +0800 ... > [ 56.462464] r8169 :02:00.0: MSI-X entry: context resume: > ... > uh! The MSI-X entry seems missed after resume on this laptop! Yeah, having all of the MSI-X entry values be all-1's is no

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread Jian-Hong Pan
2018-08-22 5:19 GMT+08:00 Heiner Kallweit : > On 20.08.2018 05:47, Jian-Hong Pan wrote: >> 2018-08-20 4:34 GMT+08:00 Heiner Kallweit : >>> The three of you reported an MSI-X-related error when the system >>> resumes from suspend. This has been fixed for now by disabling MSI-X >>> on certain chip ve

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread David Miller
From: Heiner Kallweit Date: Tue, 21 Aug 2018 23:19:04 +0200 > That's what I get on my system (RTL8168E-VL). In your case you'll come > only till the first suspend. > > [3.743404] r8169 :03:00.0: MSI-X entry: context probe: fee01004 0 > 40ef 1 On probe, MSI-X is masked (ie. disabled) an

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread Steve Dodd
On 21 August 2018 at 22:19, Heiner Kallweit wrote: > Below is a patch printing the MSI-X table entry in different contexts, > it's not supposed to fix anything. Could you please let me know > what the output is on your system? > I want to get an idea whether the issue clears the complete entry or

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread Heiner Kallweit
On 20.08.2018 05:47, Jian-Hong Pan wrote: > 2018-08-20 4:34 GMT+08:00 Heiner Kallweit : >> The three of you reported an MSI-X-related error when the system >> resumes from suspend. This has been fixed for now by disabling MSI-X >> on certain chip versions. However more versions may be affected. >>

Re: Experimental fix for MSI-X issue on r8169

2018-08-21 Thread Steve Dodd
On 20 August 2018 at 04:47, Jian-Hong Pan wrote: > There is no "MSIX address lost, re-configuring" in dmesg. > The ethernet interface is still down after resume. Sorry, only just seen this thread. I can confirm Jian-Jong's report -- this patch doesn't help (applied to 4.18.3); no message is outp

Re: Experimental fix for MSI-X issue on r8169

2018-08-19 Thread Jian-Hong Pan
2018-08-20 4:34 GMT+08:00 Heiner Kallweit : > The three of you reported an MSI-X-related error when the system > resumes from suspend. This has been fixed for now by disabling MSI-X > on certain chip versions. However more versions may be affected. > > I checked with Realtek and they confirmed that

Experimental fix for MSI-X issue on r8169

2018-08-19 Thread Heiner Kallweit
The three of you reported an MSI-X-related error when the system resumes from suspend. This has been fixed for now by disabling MSI-X on certain chip versions. However more versions may be affected. I checked with Realtek and they confirmed that on certain chip versions a MSIX-related value in PCI