Re: Ethtool question

2017-10-17 Thread Gal Pressman
On 16-Oct-17 21:10, Ben Greear wrote: > On 10/12/2017 03:00 PM, Roopa Prabhu wrote: >> On Thu, Oct 12, 2017 at 2:45 PM, Ben Greear wrote: >>> On 10/11/2017 01:49 PM, David Miller wrote: From: "John W. Linville" Date: Wed, 11 Oct 2017 16:44:07 -0400 > On Wed, Oct 11, 2017 a

Re: Ethtool question

2017-10-16 Thread Ben Greear
On 10/12/2017 03:00 PM, Roopa Prabhu wrote: On Thu, Oct 12, 2017 at 2:45 PM, Ben Greear wrote: On 10/11/2017 01:49 PM, David Miller wrote: From: "John W. Linville" Date: Wed, 11 Oct 2017 16:44:07 -0400 On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: I noticed today that setti

Re: Ethtool question

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 2:45 PM, Ben Greear wrote: > On 10/11/2017 01:49 PM, David Miller wrote: >> >> From: "John W. Linville" >> Date: Wed, 11 Oct 2017 16:44:07 -0400 >> >>> On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: I noticed today that setting some ethtool settings

Re: Ethtool question

2017-10-12 Thread Ben Greear
On 10/11/2017 01:49 PM, David Miller wrote: From: "John W. Linville" Date: Wed, 11 Oct 2017 16:44:07 -0400 On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: I noticed today that setting some ethtool settings to the same value returns an error code. I would think this should silentl

Re: Ethtool question

2017-10-11 Thread David Miller
From: "John W. Linville" Date: Wed, 11 Oct 2017 16:44:07 -0400 > On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: >> I noticed today that setting some ethtool settings to the same value >> returns an error code. I would think this should silently return >> success instead? Makes it e

Re: Ethtool question

2017-10-11 Thread John W. Linville
On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: > I noticed today that setting some ethtool settings to the same value > returns an error code. I would think this should silently return > success instead? Makes it easier to call it from scripts this way: > > [root@lf0313-6477 lanforg

Ethtool question

2017-10-11 Thread Ben Greear
I noticed today that setting some ethtool settings to the same value returns an error code. I would think this should silently return success instead? Makes it easier to call it from scripts this way: [root@lf0313-6477 lanforge]# ethtool -L eth3 combined 1 combined unmodified, ignoring no chann