Re: DM9000_IRQ_FLAGS

2008-01-15 Thread Daniel Mack
On Thu, Dec 20, 2007 at 10:54:34AM +0100, Remy Bohmer wrote: > > I did have a go at trying to get people to pass the information this > > way, but it seem to be ignored last time I sent it. I can dig out the > > code that converts resource->flags to IRQT_ flags. > > I thought this issue was alread

Re: DM9000_IRQ_FLAGS

2007-12-20 Thread Remy Bohmer
Hello Ben, > > > > Actually, the best way to go is to let the platform resources flags > > decide about that with something like > > > > resource->flags = IORESOURCE_IRQ | IRQT_RISING; > > > > but the dm9000 does not care about them at all. Changing that would also > > imply modifications to

Re: DM9000_IRQ_FLAGS

2007-12-20 Thread Ben Dooks
On Wed, Dec 12, 2007 at 02:41:53PM +0100, Daniel Mack wrote: > Hi Remy, > > On Tue, Dec 11, 2007 at 09:31:03PM +0100, Remy Bohmer wrote: > > This controller is also used on many other boards, like the e.g. Atmel > > AT91sam9261-ek board. On that board on both the rising _and_ falling > > edge an i

Re: DM9000_IRQ_FLAGS

2007-12-20 Thread Ben Dooks
On Tue, Dec 11, 2007 at 08:18:23PM +0100, Daniel Mack wrote: > Hi, > > on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet > controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS. > If I understood the code behind request_irq() correctly,

Re: DM9000_IRQ_FLAGS

2007-12-12 Thread Daniel Mack
Hi, On Dec 12, 2007, at 3:46 PM, Remy Bohmer wrote: The DM9000 adapter is connected to a GPIO line on the at91sam9261-ek board, the board-specific code has a generic handler for every GPIO interrupt. So, the Device driver __does not need to know__ the type of interrupt, It just installs a handl

Re: DM9000_IRQ_FLAGS

2007-12-12 Thread Remy Bohmer
Hello Daniel, > However, request_irq() is called with IRQF_SHARED only, so neither > IRQT_RISING nor IRQT_FALLING is set and the value defaults to > IRQT_NOEDGE. How can you get IRQs? The DM9000 adapter is connected to a GPIO line on the at91sam9261-ek board, the board-specific code has a generic

Re: DM9000_IRQ_FLAGS

2007-12-12 Thread Daniel Mack
Hi Remy, On Tue, Dec 11, 2007 at 09:31:03PM +0100, Remy Bohmer wrote: > This controller is also used on many other boards, like the e.g. Atmel > AT91sam9261-ek board. On that board on both the rising _and_ falling > edge an interrupt is generated. However, request_irq() is called with IRQF_SHARED

Re: DM9000_IRQ_FLAGS

2007-12-11 Thread Remy Bohmer
board with a DM9000 ethernet > controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS. > If I understood the code behind request_irq() correctly, it's not > recommended to register an IRQ without any of the IRQT_* flags set. > > Is there any concerns abo

DM9000_IRQ_FLAGS

2007-12-11 Thread Daniel Mack
Hi, on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS. If I understood the code behind request_irq() correctly, it's not recommended to register an IRQ without any of the IRQT_* flags set. Is the