Re: CHECKSUM_UNNECESSARY semantics with driver modified.created packets

2017-02-17 Thread Tom Herbert
On Fri, Feb 17, 2017 at 1:04 PM, Tom Herbert wrote: > Alexei and I were looking at the mlx5 LRO code this morning. One > discrepancy I noticed with GRO is that CHECKSUM_UNNECESSARY is set for > the assembled packet whereas in GRO we use CHECKSUM_PARTIAL. The > effect of using checksum-unnecessary

CHECKSUM_UNNECESSARY semantics with driver modified.created packets

2017-02-17 Thread Tom Herbert
Alexei and I were looking at the mlx5 LRO code this morning. One discrepancy I noticed with GRO is that CHECKSUM_UNNECESSARY is set for the assembled packet whereas in GRO we use CHECKSUM_PARTIAL. The effect of using checksum-unnecessary is that the actual TCP checksum in the packet is not correct