Re: [PATCH net v2] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-07 Thread David Miller
From: Alex Sidorenko Date: Fri, 07 Oct 2016 09:02:33 -0400 > Roundrobin runner of team driver uses 'unsigned int' variable to count > the number of sent_packets. Later it is passed to a subroutine > team_num_to_port_index(struct team *team, int num) as 'num' and when > we reach MAXINT (2**31-1),

[PATCH net v2] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-07 Thread Alex Sidorenko
Roundrobin runner of team driver uses 'unsigned int' variable to count the number of sent_packets. Later it is passed to a subroutine team_num_to_port_index(struct team *team, int num) as 'num' and when we reach MAXINT (2**31-1), 'num' becomes negative. This leads to using incorrect hash-bucket fo

Re: [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-05 Thread David Miller
From: Alex Sidorenko Date: Wed, 05 Oct 2016 09:06:04 -0400 > Roundrobin runner of team driver uses 'unsigned int' variable to count the > number of sent_packets. > Later it is passed to a subroutine team_num_to_port_index(struct team *team, > int num) as > 'num' and when we reach MAXINT (2**31-

Re: [PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-05 Thread Eric Dumazet
On Wed, 2016-10-05 at 09:06 -0400, Alex Sidorenko wrote: > Roundrobin runner of team driver uses 'unsigned int' variable to count the > number of sent_packets. > Later it is passed to a subroutine team_num_to_port_index(struct team *team, > int num) as > 'num' and when we reach MAXINT (2**31-1),

[PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-05 Thread Alex Sidorenko
Roundrobin runner of team driver uses 'unsigned int' variable to count the number of sent_packets. Later it is passed to a subroutine team_num_to_port_index(struct team *team, int num) as 'num' and when we reach MAXINT (2**31-1), 'num' becomes negative. This leads to using incorrect hash-bucket

Re: A bug in team driver

2016-10-04 Thread Eric Dumazet
On Tue, 2016-10-04 at 18:30 -0400, Alex Sidorenko wrote: > The problem was found on RHEL7.2 but is still present in the latest > upstream kernel (according to visual sources inspection). > > While using roundrobin runner we have noticed that after sending on > team0 about 2.1 billion packets we st

A bug in team driver

2016-10-04 Thread Alex Sidorenko
The problem was found on RHEL7.2 but is still present in the latest upstream kernel (according to visual sources inspection). While using roundrobin runner we have noticed that after sending on team0 about 2.1 billion packets we started seeing 50% packet drop on team0 (according to 'netstat -i'