Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 11 Sep 2007 20:43:27 +0800 > On Tue, Sep 11, 2007 at 08:01:46AM -0400, jamal wrote: > > > > [NET_SCHED] protect action config/dump from irqs > > Looks good! Thanks Jamal. Applied, I'll try to push this in some time soon. - To unsubscribe from this

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-11 Thread Herbert Xu
On Tue, Sep 11, 2007 at 08:01:46AM -0400, jamal wrote: > > [NET_SCHED] protect action config/dump from irqs Looks good! Thanks Jamal. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gond

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-11 Thread jamal
On Tue, 2007-11-09 at 10:18 +0800, Herbert Xu wrote: > Jamal, it's the police_lock that we need to make _bh. The > ingress_lock is already _bh because of the spin_lock_bh that > directly precedes it. > > Oh and I think the same thing applies for the other actions > too. ga-Dang. Ok, here it is.

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-10 Thread Herbert Xu
On Mon, Sep 10, 2007 at 08:04:41PM -0400, jamal wrote: > > disabling BH would make it more symmetric to the way we handle > egress. I couldnt reproduce the issue, but this should hopefully resolve > it. > Christian, can you test with this patch? Jamal, it's the police_lock that we need to make _bh

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-10 Thread jamal
On Mon, 2007-10-09 at 21:00 +0800, Herbert Xu wrote: > The minimal fix would be to make sure that we disable BH on > the first CPU. disabling BH would make it more symmetric to the way we handle egress. I couldnt reproduce the issue, but this should hopefully resolve it. Christian, can you test

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-10 Thread Herbert Xu
On Sun, Sep 02, 2007 at 01:11:29PM +, Christian Kujau wrote: > > after upgrading to 2.6.23-rc5 (and applying davem's fix [0]), lockdep > was quite noisy when I tried to shape my external (wireless) interface: > > [ 6400.534545] FahCore_78.exe/3552 just changed the state of lock: > [ 6400.534

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-10 Thread Peter Zijlstra
On Sun, 2007-09-02 at 15:11 +0200, Christian Kujau wrote: > Hi, > > after upgrading to 2.6.23-rc5 (and applying davem's fix [0]), lockdep > was quite noisy when I tried to shape my external (wireless) interface: > > [ 6400.534545] FahCore_78.exe/3552 just changed the state of lock: > [ 6400.5347

2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-02 Thread Christian Kujau
Hi, after upgrading to 2.6.23-rc5 (and applying davem's fix [0]), lockdep was quite noisy when I tried to shape my external (wireless) interface: [ 6400.534545] FahCore_78.exe/3552 just changed the state of lock: [ 6400.534713] (&dev->ingress_lock){-+..}, at: [] netif_receive_skb+0x2d5/0x3c0