Re: [v2] ioctl: only memset non-NULL link settings

2020-08-27 Thread Michal Kubecek
On Thu, Aug 27, 2020 at 11:50:33AM +0200, Hans-Christian Noren Egtvedt wrote: > In commit bef780467fa ('ioctl: do not pass transceiver value back to > kernel') a regression slipped in. If we have a kernel that does not > support the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() > fun

[v2] ioctl: only memset non-NULL link settings

2020-08-27 Thread Hans-Christian Noren Egtvedt
In commit bef780467fa ('ioctl: do not pass transceiver value back to kernel') a regression slipped in. If we have a kernel that does not support the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings() function will return a NULL pointer. Hence before memset'ing the pointer to zero we must