Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-11-08 Thread David Kimdon
On Thu, Nov 02, 2006 at 10:30:56PM -0500, John W. Linville wrote: > David, may I presume there will be a "take4"? yes, refreshing is in progress. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-11-02 Thread John W. Linville
On Wed, Oct 25, 2006 at 03:28:03PM -0400, Jeff Garzik wrote: > On Wed, Oct 25, 2006 at 12:17:02PM -0700, David Kimdon wrote: > > That is how I originally had the patch, but then had a question about > > increasing structure size so I dropped flags to u16 or u8 for > > structures that were made larg

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-25 Thread Jeff Garzik
On Wed, Oct 25, 2006 at 12:17:02PM -0700, David Kimdon wrote: > That is how I originally had the patch, but then had a question about > increasing structure size so I dropped flags to u16 or u8 for > structures that were made larger by the bitfield removal. On non-x86 platforms, u16 and u8 generat

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-25 Thread David Kimdon
On Wed, Oct 25, 2006 at 03:01:29PM -0400, Jeff Garzik wrote: > On Wed, Oct 25, 2006 at 11:42:44AM -0700, David Kimdon wrote: > > Continue d80211 bitfield removal. In general, compilers have > > difficulty generating efficient code for bitfields. This patchset > > removes all bitfields from includ

Re: [take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-25 Thread Jeff Garzik
On Wed, Oct 25, 2006 at 11:42:44AM -0700, David Kimdon wrote: > Continue d80211 bitfield removal. In general, compilers have > difficulty generating efficient code for bitfields. This patchset > removes all bitfields from include/net/d80211.h. > > I converted the 1 bit bitfields into a bit in a

[take3 0/5] d80211: remove bitfields from include/net/d80211.h

2006-10-25 Thread David Kimdon
Continue d80211 bitfield removal. In general, compilers have difficulty generating efficient code for bitfields. This patchset removes all bitfields from include/net/d80211.h. I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags structure member. Larger bitfields I converted into