Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-02-06 Thread Guillaume Nault
On Fri, Jan 26, 2018 at 11:51:38AM +0100, Guillaume Nault wrote: > On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: > > On 01/25/2018 03:58 PM, Guillaume Nault wrote: > > > Hi, > > > > > > Commit 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct > > > ethhdr"), > > > c

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-01-26 Thread David Miller
From: Guillaume Nault Date: Fri, 26 Jan 2018 18:17:23 +0100 > On Fri, Jan 26, 2018 at 11:51:38AM +0100, Guillaume Nault wrote: >> On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: >> > On 01/25/2018 03:58 PM, Guillaume Nault wrote: >> > > Now that linux/libc-compat.h is included in

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-01-26 Thread Guillaume Nault
On Fri, Jan 26, 2018 at 11:51:38AM +0100, Guillaume Nault wrote: > On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: > > On 01/25/2018 03:58 PM, Guillaume Nault wrote: > > > Now that linux/libc-compat.h is included in linux/if_ether.h, it is > > > processed before netinet/in.h. Theref

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-01-26 Thread Guillaume Nault
On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: > On 01/25/2018 03:58 PM, Guillaume Nault wrote: > > Hi, > > > > Commit 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct > > ethhdr"), > > can break compilation of userspace programs (in my case, accel-ppp > > (https://

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-01-25 Thread Hauke Mehrtens
On 01/25/2018 03:58 PM, Guillaume Nault wrote: > Hi, > > Commit 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct > ethhdr"), > can break compilation of userspace programs (in my case, accel-ppp > (https://accel-ppp.org)). > > This happens for userspace programs that end up includin

[regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-01-25 Thread Guillaume Nault
Hi, Commit 6926e041a892 ("uapi/if_ether.h: prevent redefinition of struct ethhdr"), can break compilation of userspace programs (in my case, accel-ppp (https://accel-ppp.org)). This happens for userspace programs that end up including linux/if_ether.h, netinet/in.h and linux/in.h in this order: