Re: [patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-10 Thread Jakub Kicinski
On Mon, 10 Jun 2019 15:56:00 -0600, David Ahern wrote: > On 6/10/19 11:47 AM, Jakub Kicinski wrote: > > It's the kernel that does this, the request_firmware() API. It's > > documented in both devlink's and ethtool's API. I was initially > > intending to use the file request API directly in devlin

Re: [patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-10 Thread David Ahern
On 6/10/19 11:47 AM, Jakub Kicinski wrote: > It's the kernel that does this, the request_firmware() API. It's > documented in both devlink's and ethtool's API. I was initially > intending to use the file request API directly in devlink, but because > of the requirement to keep compatibility with

Re: [patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-10 Thread Jakub Kicinski
On Mon, 10 Jun 2019 11:30:24 -0600, David Ahern wrote: > On 6/10/19 11:24 AM, Jakub Kicinski wrote: > > On Mon, 10 Jun 2019 11:09:19 -0600, David Ahern wrote: > >> On 6/4/19 7:44 AM, Jiri Pirko wrote: > >>> diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8 > >>> index 1804463b2321..1

Re: [patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-10 Thread David Ahern
On 6/10/19 11:24 AM, Jakub Kicinski wrote: > On Mon, 10 Jun 2019 11:09:19 -0600, David Ahern wrote: >> On 6/4/19 7:44 AM, Jiri Pirko wrote: >>> diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8 >>> index 1804463b2321..1021ee8d064c 100644 >>> --- a/man/man8/devlink-dev.8 >>> +++ b/man/man

Re: [patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-10 Thread Jakub Kicinski
On Mon, 10 Jun 2019 11:09:19 -0600, David Ahern wrote: > On 6/4/19 7:44 AM, Jiri Pirko wrote: > > diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8 > > index 1804463b2321..1021ee8d064c 100644 > > --- a/man/man8/devlink-dev.8 > > +++ b/man/man8/devlink-dev.8 > > @@ -244,6 +244,17 @@ Sets

Re: [patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-10 Thread David Ahern
On 6/4/19 7:44 AM, Jiri Pirko wrote: > diff --git a/man/man8/devlink-dev.8 b/man/man8/devlink-dev.8 > index 1804463b2321..1021ee8d064c 100644 > --- a/man/man8/devlink-dev.8 > +++ b/man/man8/devlink-dev.8 > @@ -244,6 +244,17 @@ Sets the parameter internal_error_reset of specified > devlink device t

[patch net-next v3 3/3] devlink: implement flash status monitoring

2019-06-04 Thread Jiri Pirko
From: Jiri Pirko Listen to status notifications coming from kernel during flashing and put them on stdout to inform user about the status. Signed-off-by: Jiri Pirko --- v2->v3: - added example in man v1->v2: - fixed endless loop bug in case of no notifications --- devlink/devlink.c | 209