Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-24 Thread Hannes Frederic Sowa
On 24.11.2016 09:47, Ido Schimmel wrote: > On Thu, Nov 24, 2016 at 12:04:57AM +0100, Hannes Frederic Sowa wrote: >> On 23.11.2016 20:53, Ido Schimmel wrote: >>> On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: Hmm, I think you need to read the sequence counter under rtnl_l

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-24 Thread Ido Schimmel
On Thu, Nov 24, 2016 at 12:04:57AM +0100, Hannes Frederic Sowa wrote: > On 23.11.2016 20:53, Ido Schimmel wrote: > > On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: > >> Hmm, I think you need to read the sequence counter under rtnl_lock to > >> have an ordering with the rest o

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-23 Thread Hannes Frederic Sowa
On 23.11.2016 20:53, Ido Schimmel wrote: > On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: >> Hmm, I think you need to read the sequence counter under rtnl_lock to >> have an ordering with the rest of the updates to the RCU trie. Otherwise >> you don't know if the fib trie has

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-23 Thread Ido Schimmel
On Wed, Nov 23, 2016 at 06:47:03PM +0100, Hannes Frederic Sowa wrote: > Hmm, I think you need to read the sequence counter under rtnl_lock to > have an ordering with the rest of the updates to the RCU trie. Otherwise > you don't know if the fib trie has the correct view regarding to the > incoming

Re: [patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-23 Thread Hannes Frederic Sowa
On 23.11.2016 15:34, Jiri Pirko wrote: > From: Ido Schimmel > > Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") > introduced a new notification chain to notify listeners (f.e., switchdev > drivers) about addition and deletion of routes. > > However, upon registration to th

[patch net-next v2 09/11] ipv4: fib: Add an API to request a FIB dump

2016-11-23 Thread Jiri Pirko
From: Ido Schimmel Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") introduced a new notification chain to notify listeners (f.e., switchdev drivers) about addition and deletion of routes. However, upon registration to the chain the FIB tables can already be populated, whic