Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-27 Thread Jiri Pirko
Sat, May 25, 2019 at 02:08:52AM CEST, jakub.kicin...@netronome.com wrote: >On Sat, 25 May 2019 00:26:35 +0200, Jiri Pirko wrote: >> Fri, May 24, 2019 at 05:54:46PM CEST, jakub.kicin...@netronome.com wrote: >> >On Fri, 24 May 2019 10:11:10 +0200, Jiri Pirko wrote: >> >> Thu, May 23, 2019 at 05:19:

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-24 Thread Jakub Kicinski
On Sat, 25 May 2019 00:26:35 +0200, Jiri Pirko wrote: > Fri, May 24, 2019 at 05:54:46PM CEST, jakub.kicin...@netronome.com wrote: > >On Fri, 24 May 2019 10:11:10 +0200, Jiri Pirko wrote: > >> Thu, May 23, 2019 at 05:19:46PM CEST, dsah...@gmail.com wrote: > >> >On 5/23/19 3:45 AM, Jiri Pirko wro

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-24 Thread Jiri Pirko
Fri, May 24, 2019 at 05:54:46PM CEST, jakub.kicin...@netronome.com wrote: >On Fri, 24 May 2019 10:11:10 +0200, Jiri Pirko wrote: >> Thu, May 23, 2019 at 05:19:46PM CEST, dsah...@gmail.com wrote: >> >On 5/23/19 3:45 AM, Jiri Pirko wrote: >> >> @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(st

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-24 Thread Jakub Kicinski
On Fri, 24 May 2019 10:11:10 +0200, Jiri Pirko wrote: > Thu, May 23, 2019 at 05:19:46PM CEST, dsah...@gmail.com wrote: > >On 5/23/19 3:45 AM, Jiri Pirko wrote: > >> @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct mlxfw_dev > >> *mlxfw_dev, u32 fwhandle, > >>if (fsm_state_err != ML

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-24 Thread Jiri Pirko
Thu, May 23, 2019 at 05:19:46PM CEST, dsah...@gmail.com wrote: >On 5/23/19 3:45 AM, Jiri Pirko wrote: >> @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct mlxfw_dev >> *mlxfw_dev, u32 fwhandle, >> if (fsm_state_err != MLXFW_FSM_STATE_ERR_OK) { >> pr_err("Firmware flash f

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-23 Thread Saeed Mahameed
On Thu, 2019-05-23 at 09:19 -0600, David Ahern wrote: > On 5/23/19 3:45 AM, Jiri Pirko wrote: > > @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct > > mlxfw_dev *mlxfw_dev, u32 fwhandle, > > if (fsm_state_err != MLXFW_FSM_STATE_ERR_OK) { > > pr_err("Firmware flash failed:

Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-23 Thread David Ahern
On 5/23/19 3:45 AM, Jiri Pirko wrote: > @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct mlxfw_dev > *mlxfw_dev, u32 fwhandle, > if (fsm_state_err != MLXFW_FSM_STATE_ERR_OK) { > pr_err("Firmware flash failed: %s\n", > mlxfw_fsm_state_err_str[fsm_s

[patch net-next 3/7] mlxfw: Propagate error messages through extack

2019-05-23 Thread Jiri Pirko
From: Jiri Pirko Currently the error messages are printed to dmesg. Propagate them also to directly to user doing the flashing through extack. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx5/core/fw.c | 6 ++-- .../net/ethernet/mellanox/mlx5/core/main.c| 2 +- .../ether