Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-31 Thread Jiri Pirko
Mon, Jul 31, 2017 at 10:37:21PM CEST, xiyou.wangc...@gmail.com wrote: >On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote: >> +static inline int >> +tcf_exts_exec(struct sk_buff *skb, struct tcf_exts *exts, >> + struct tcf_result *res) >> +{ >> +#ifdef CONFIG_NET_CLS_ACT >> + if (

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-31 Thread Cong Wang
On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote: > +static inline int > +tcf_exts_exec(struct sk_buff *skb, struct tcf_exts *exts, > + struct tcf_result *res) > +{ > +#ifdef CONFIG_NET_CLS_ACT > + if (tcf_exts_has_actions(exts)) > + return tcf_action_exec(skb, ext

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-31 Thread Jiri Pirko
Mon, Jul 31, 2017 at 02:09:22PM CEST, j...@mojatatu.com wrote: >On 17-07-31 02:36 AM, Jiri Pirko wrote: >> Sun, Jul 30, 2017 at 09:48:24PM CEST, j...@mojatatu.com wrote: >> > I am probably missing something. All those changes to just >> > replace "if (exts->nr_actions)" with "if (tcf_exts_has_actio

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-31 Thread Jamal Hadi Salim
On 17-07-31 02:36 AM, Jiri Pirko wrote: Sun, Jul 30, 2017 at 09:48:24PM CEST, j...@mojatatu.com wrote: I am probably missing something. All those changes to just replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ? That is what the description says :) I meant I wouldve e

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-30 Thread Jiri Pirko
Sun, Jul 30, 2017 at 09:48:24PM CEST, j...@mojatatu.com wrote: >I am probably missing something. All those changes to just >replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ? That is what the description says :) > >cheers, >jamal > >On 17-07-28 10:40 AM, Jiri Pirko wrote: >

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-30 Thread Jamal Hadi Salim
I am probably missing something. All those changes to just replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ? cheers, jamal On 17-07-28 10:40 AM, Jiri Pirko wrote: From: Jiri Pirko Use the tcf_exts_has_actions helper instead or directly testing exts->nr_actions in tcf_ex

[patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-28 Thread Jiri Pirko
From: Jiri Pirko Use the tcf_exts_has_actions helper instead or directly testing exts->nr_actions in tcf_exts_exec. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/include/n