RE: [patch net-next 01/16] net: add dev arg to ndo_neigh_construct/destroy

2016-07-05 Thread Yuval Mintz
> - int (*ndo_neigh_construct)(struct neighbour *n); > - void(*ndo_neigh_destroy)(struct neighbour *n); > + int (*ndo_neigh_construct)(struct net_device > *dev, > +struct neig

RE: [patch net-next 01/16] net: add dev arg to ndo_neigh_construct/destroy

2016-07-05 Thread Yuval Mintz
> As the following patch will allow upper devices to follow the call down lower > devices, we need to add dev here and not rely on n->dev. How does all of this relates to neigh_alloc()? Is it being called only for the lower devices? I'm asking as it appears that __neigh_create() would allocates me

Re: [patch net-next 01/16] net: add dev arg to ndo_neigh_construct/destroy

2016-07-05 Thread Jiri Pirko
Tue, Jul 05, 2016 at 01:04:09PM CEST, yuval.mi...@qlogic.com wrote: >> -int (*ndo_neigh_construct)(struct neighbour *n); >> -void(*ndo_neigh_destroy)(struct neighbour *n); >> +int (*ndo_neigh_construct)(struct net_device >> *de

Re: [patch net-next 01/16] net: add dev arg to ndo_neigh_construct/destroy

2016-07-05 Thread Jiri Pirko
Tue, Jul 05, 2016 at 01:03:36PM CEST, yuval.mi...@qlogic.com wrote: >> As the following patch will allow upper devices to follow the call down lower >> devices, we need to add dev here and not rely on n->dev. > >How does all of this relates to neigh_alloc()? Is it being called only for the >lower d

[patch net-next 01/16] net: add dev arg to ndo_neigh_construct/destroy

2016-07-05 Thread Jiri Pirko
From: Jiri Pirko As the following patch will allow upper devices to follow the call down lower devices, we need to add dev here and not rely on n->dev. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/rocker/rocker_main.c | 3 ++- include/linux/netdevice.h