Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread Cong Wang
On Fri, Mar 24, 2017 at 12:46 PM, David Miller wrote: > From: Cong Wang > Date: Fri, 24 Mar 2017 10:59:15 -0700 > >> On Thu, Mar 23, 2017 at 9:02 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> sch_choke is classless qdisc so it does not define cl_ops. Therefore >>> filter_list cannot be eve

Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread David Miller
From: Jiri Pirko Date: Thu, 23 Mar 2017 17:02:16 +0100 > From: Jiri Pirko > > sch_choke is classless qdisc so it does not define cl_ops. Therefore > filter_list cannot be ever changed, being NULL all the time. > Reason is this check in tc_ctl_tfilter: > > /* Is it classful? */ > co

Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread David Miller
From: Cong Wang Date: Fri, 24 Mar 2017 10:59:15 -0700 > On Thu, Mar 23, 2017 at 9:02 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> sch_choke is classless qdisc so it does not define cl_ops. Therefore >> filter_list cannot be ever changed, being NULL all the time. >> Reason is this check in tc

Re: [patch net-next] net: sched: choke: remove dead filter classify code

2017-03-24 Thread Cong Wang
On Thu, Mar 23, 2017 at 9:02 AM, Jiri Pirko wrote: > From: Jiri Pirko > > sch_choke is classless qdisc so it does not define cl_ops. Therefore > filter_list cannot be ever changed, being NULL all the time. > Reason is this check in tc_ctl_tfilter: Are you sure? According to the definition in com

[patch net-next] net: sched: choke: remove dead filter classify code

2017-03-23 Thread Jiri Pirko
From: Jiri Pirko sch_choke is classless qdisc so it does not define cl_ops. Therefore filter_list cannot be ever changed, being NULL all the time. Reason is this check in tc_ctl_tfilter: /* Is it classful? */ cops = q->ops->cl_ops; if (!cops) return -EINVA