Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-12 Thread David Miller
From: Jiri Pirko Date: Fri, 9 Oct 2015 13:54:11 +0200 > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id. > > Signed-off-by: Jiri Pirko > Sign

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-11 Thread Scott Feldman
On Sat, Oct 10, 2015 at 9:03 AM, Vivien Didelot wrote: > On Oct. Friday 09 (41) 08:20 PM, Scott Feldman wrote: >> On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot >> wrote: >> > Hi Jiri, >> > >> > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> Some drivers ne

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-10 Thread Florian Fainelli
2015-10-10 0:01 GMT-07:00 Jiri Pirko : > Sat, Oct 10, 2015 at 05:20:28AM CEST, sfel...@gmail.com wrote: >>On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot >> wrote: >>> Hi Jiri, >>> >>> On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: From: Jiri Pirko Some drivers need to implement

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-10 Thread Vivien Didelot
On Oct. Friday 09 (41) 08:20 PM, Scott Feldman wrote: > On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot > wrote: > > Hi Jiri, > > > > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Some drivers need to implement both switchdev vlan ops and > >> vid_add/kill ndos

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-10 Thread Jiri Pirko
Sat, Oct 10, 2015 at 05:20:28AM CEST, sfel...@gmail.com wrote: >On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot > wrote: >> Hi Jiri, >> >> On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Some drivers need to implement both switchdev vlan ops and >>> vid_add/kill ndos

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Scott Feldman
On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot wrote: > Hi Jiri, > > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Some drivers need to implement both switchdev vlan ops and >> vid_add/kill ndos. For that to work in bridge code, we need to try >> switchdev op first

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Scott Feldman
On Fri, Oct 9, 2015 at 4:54 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id. > > Signed-off-by: Jiri Pirko > Signed-off-b

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Vivien Didelot
Hi Jiri, On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id. Just curious, when would a driver

[patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-09 Thread Jiri Pirko
From: Jiri Pirko Some drivers need to implement both switchdev vlan ops and vid_add/kill ndos. For that to work in bridge code, we need to try switchdev op first when adding/deleting vlan id. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- net/bridge/br_vlan.c | 58 +