Re: [patch net] net: fec: cache statistics while device is down

2016-11-28 Thread Nikita Yushchenko
> > > >+ fec_enet_update_ethtool_stats(ndev); > >+ > If user never open the interface, ethtool_stats[] always is 0 that are not > expected. > So, it also should be called at . fec_enet_init() ? I don't think that zero stats is wrong for never-opened interface. However a call at init path wo

RE: [patch net] net: fec: cache statistics while device is down

2016-11-28 Thread Andy Duan
; Nikita >Yushchenko >Subject: [patch net] net: fec: cache statistics while device is down > >Execution 'ethtool -S' on fec device that is down causes OOPS on Vybrid >board: > >Unhandled fault: external abort on non-linefetch (0x1008) at 0xe0898200 pgd >=

[patch net] net: fec: cache statistics while device is down

2016-11-28 Thread Nikita Yushchenko
Execution 'ethtool -S' on fec device that is down causes OOPS on Vybrid board: Unhandled fault: external abort on non-linefetch (0x1008) at 0xe0898200 pgd = ddecc000 [e0898200] *pgd=9e406811, *pte=400d1653, *ppte=400d1453 Internal error: : 1008 [#1] SMP ARM ... Reason of OOPS is that fec_enet_get