Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-13 Thread Andi Kleen
Stephen Hemminger <[EMAIL PROTECTED]> writes: > > /* > * FIXME: On x86 and some other CPUs the split into user and softirq parts > * is not needed because addl $1,memory is atomic against interrupts (but > * atomic_inc would be overkill because of the lock cycles). Wants new > * nonlocked_a

Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 14:26:47 -0700 > On Mon, 12 Mar 2007 14:15:50 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > Look at the definition of DEFINE_SNMP_STAT(). > > Okay, that's confusing. And maybe the comment suggests future work: Inde

Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread Stephen Hemminger
On Mon, 12 Mar 2007 14:15:50 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 12 Mar 2007 14:08:21 -0700 > > > The TCP statistics shouldn't be located in the middle of the > > read_mostly section surrounded by sysctl values. > > Move E

Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Mar 2007 14:08:21 -0700 > The TCP statistics shouldn't be located in the middle of the > read_mostly section surrounded by sysctl values. > Move EXPORT_SYMBOL next to data like other declarations near by. > > Signed-off-by: Stephen Hemming

[patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread Stephen Hemminger
The TCP statistics shouldn't be located in the middle of the read_mostly section surrounded by sysctl values. Move EXPORT_SYMBOL next to data like other declarations near by. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/tcp.c |4 ++-- 1 file changed, 2 insertions(+), 2 d