Re: [patch 24/35] net: brcmfmac: Replace in_interrupt()

2020-09-28 Thread Arend Van Spriel
On 9/27/2020 9:49 PM, Thomas Gleixner wrote: From: Sebastian Andrzej Siewior brcmf_sdio_isr() is using in_interrupt() to distinguish if it is called from a interrupt service routine or from a worker thread. Passing such information from the calling context is preferred and requested by Linus,

Re: [patch 24/35] net: brcmfmac: Replace in_interrupt()

2020-09-28 Thread Arend Van Spriel
On 9/28/2020 11:19 AM, Ulf Hansson wrote: On Mon, 28 Sep 2020 at 09:35, Arend Van Spriel wrote: + Uffe On 9/27/2020 9:49 PM, Thomas Gleixner wrote: @@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st brcmf_dbg(INTR, "IB intr triggered\n"); - brcmf_sdio_isr(sdiodev->bus);

Re: [patch 24/35] net: brcmfmac: Replace in_interrupt()

2020-09-28 Thread Ulf Hansson
On Mon, 28 Sep 2020 at 09:35, Arend Van Spriel wrote: > > + Uffe > > On 9/27/2020 9:49 PM, Thomas Gleixner wrote: > > @@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st > > > > brcmf_dbg(INTR, "IB intr triggered\n"); > > > > - brcmf_sdio_isr(sdiodev->bus); > > + brcmf_sdio_is

Re: [patch 24/35] net: brcmfmac: Replace in_interrupt()

2020-09-28 Thread Arend Van Spriel
+ Uffe On 9/27/2020 9:49 PM, Thomas Gleixner wrote: @@ -85,7 +85,7 @@ static void brcmf_sdiod_ib_irqhandler(st brcmf_dbg(INTR, "IB intr triggered\n"); - brcmf_sdio_isr(sdiodev->bus); + brcmf_sdio_isr(sdiodev->bus, false); } Hi Uffe, I assume the above code is okay, but want

[patch 24/35] net: brcmfmac: Replace in_interrupt()

2020-09-27 Thread Thomas Gleixner
From: Sebastian Andrzej Siewior brcmf_sdio_isr() is using in_interrupt() to distinguish if it is called from a interrupt service routine or from a worker thread. Passing such information from the calling context is preferred and requested by Linus, so add an argument `in_isr' to brcmf_sdio_isr()