Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-27 Thread Andrew Morton
On Fri, 27 Apr 2007 20:10:54 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Ingo Molnar <[EMAIL PROTECTED]> > > > > Another forcedeth.c thing: i noticed that its NAPI handler does not do > > tx-ring processing. The patch below implements this - tested on DESC_V

Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-27 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Ingo Molnar <[EMAIL PROTECTED]> Another forcedeth.c thing: i noticed that its NAPI handler does not do tx-ring processing. The patch below implements this - tested on DESC_VER_2 hardware, with CONFIG_FORCEDETH_NAPI=y. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]

Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-27 Thread Lennart Sorensen
On Thu, Apr 26, 2007 at 10:53:04AM -0400, Ayaz Abdulla wrote: > Ok. In that case, the patch needs to be improved. > > The following needs to be done when NAPI is enabled: > - remove the tx handling within the ISRs > - mask off the tx interrupts within the ISRs that handle tx processing > - re-enab

Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-27 Thread Jeff Garzik
Ayaz Abdulla wrote: Jeff Garzik wrote: Ayaz Abdulla wrote: I don't see why the NAPI handler needs to process tx packets. The ISR will handle all tx processing. It is a design choice, not a requirement. Moving non-RX interrupt processing to the NAPI handler can help as loads increase. T

Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-26 Thread Ayaz Abdulla
Jeff Garzik wrote: Ayaz Abdulla wrote: I don't see why the NAPI handler needs to process tx packets. The ISR will handle all tx processing. It is a design choice, not a requirement. Moving non-RX interrupt processing to the NAPI handler can help as loads increase. The basic idea is to d

Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-26 Thread Jeff Garzik
Ayaz Abdulla wrote: I don't see why the NAPI handler needs to process tx packets. The ISR will handle all tx processing. It is a design choice, not a requirement. Moving non-RX interrupt processing to the NAPI handler can help as loads increase. The basic idea is to do as much work as possib

Re: [patch 09/11] forcedeth: improve NAPI logic

2007-04-26 Thread Ayaz Abdulla
I don't see why the NAPI handler needs to process tx packets. The ISR will handle all tx processing. [EMAIL PROTECTED] wrote: From: Ingo Molnar <[EMAIL PROTECTED]> Another forcedeth.c thing: i noticed that its NAPI handler does not do tx-ring processing. The patch below implements this - tes

[patch 09/11] forcedeth: improve NAPI logic

2007-04-26 Thread akpm
From: Ingo Molnar <[EMAIL PROTECTED]> Another forcedeth.c thing: i noticed that its NAPI handler does not do tx-ring processing. The patch below implements this - tested on DESC_VER_2 hardware, with CONFIG_FORCEDETH_NAPI=y. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: Ayaz Abdulla <[EMAIL