Re: [patch] ethernet: micrel: fix some error codes

2016-03-18 Thread David Miller
From: Dan Carpenter Date: Wed, 16 Mar 2016 10:45:10 +0300 > There were two issues here: > 1) dma_mapping_error() return true/false but we want to return -ENOMEM > 2) If dmaengine_prep_slave_sg() failed then "err" wasn't set but >presumably that should be -ENOMEM as well. > > I changed the su

[patch] ethernet: micrel: fix some error codes

2016-03-16 Thread Dan Carpenter
There were two issues here: 1) dma_mapping_error() return true/false but we want to return -ENOMEM 2) If dmaengine_prep_slave_sg() failed then "err" wasn't set but presumably that should be -ENOMEM as well. I changed the success path to "return 0;" instead of "return ret;" for clarity. Fixes: