Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread Alexander Duyck
On Tue, Mar 29, 2016 at 2:13 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: >> This patch should fix the issues seen with a recent fix to prevent >> tunnel-in-tunnel frames from being generated with GRO. The fix itself is >> correct for now as long as we do not

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread Tom Herbert
On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: > This patch should fix the issues seen with a recent fix to prevent > tunnel-in-tunnel frames from being generated with GRO. The fix itself is > correct for now as long as we do not add any devices that support > NETIF_F_GSO_GRE_CSUM. When

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-29 Thread David Miller
From: Tom Herbert Date: Mon, 28 Mar 2016 21:51:17 -0700 > No, but I do expect that you support code that is already there. There > was apparently zero testing done on the original patch and it caused > one very obvious regression. So how can we have any confidence > whatsoever that this patch doe

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Tom Herbert
On Mon, Mar 28, 2016 at 9:15 PM, Alex Duyck wrote: > On Mon, Mar 28, 2016 at 9:01 PM, Tom Herbert wrote: >> On Mon, Mar 28, 2016 at 8:27 PM, Alexander Duyck >> wrote: >>> On Mon, Mar 28, 2016 at 8:17 PM, Tom Herbert wrote: On Mon, Mar 28, 2016 at 6:54 PM, Jesse Gross wrote: > On Mon,

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Alex Duyck
On Mon, Mar 28, 2016 at 9:01 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 8:27 PM, Alexander Duyck > wrote: >> On Mon, Mar 28, 2016 at 8:17 PM, Tom Herbert wrote: >>> On Mon, Mar 28, 2016 at 6:54 PM, Jesse Gross wrote: On Mon, Mar 28, 2016 at 6:24 PM, Tom Herbert wrote: > On Mon,

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Tom Herbert
On Mon, Mar 28, 2016 at 8:27 PM, Alexander Duyck wrote: > On Mon, Mar 28, 2016 at 8:17 PM, Tom Herbert wrote: >> On Mon, Mar 28, 2016 at 6:54 PM, Jesse Gross wrote: >>> On Mon, Mar 28, 2016 at 6:24 PM, Tom Herbert wrote: On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: >

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Alexander Duyck
On Mon, Mar 28, 2016 at 8:17 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 6:54 PM, Jesse Gross wrote: >> On Mon, Mar 28, 2016 at 6:24 PM, Tom Herbert wrote: >>> On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck >>> wrote: This patch should fix the issues seen with a recent fix to preve

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Tom Herbert
On Mon, Mar 28, 2016 at 6:54 PM, Jesse Gross wrote: > On Mon, Mar 28, 2016 at 6:24 PM, Tom Herbert wrote: >> On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: >>> This patch should fix the issues seen with a recent fix to prevent >>> tunnel-in-tunnel frames from being generated with GRO.

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Jesse Gross
On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: > This patch should fix the issues seen with a recent fix to prevent > tunnel-in-tunnel frames from being generated with GRO. The fix itself is > correct for now as long as we do not add any devices that support > NETIF_F_GSO_GRE_CSUM. When

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Jesse Gross
On Mon, Mar 28, 2016 at 6:24 PM, Tom Herbert wrote: > On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: >> This patch should fix the issues seen with a recent fix to prevent >> tunnel-in-tunnel frames from being generated with GRO. The fix itself is >> correct for now as long as we do not

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Tom Herbert
On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: > This patch should fix the issues seen with a recent fix to prevent > tunnel-in-tunnel frames from being generated with GRO. The fix itself is > correct for now as long as we do not add any devices that support > NETIF_F_GSO_GRE_CSUM. When

Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Tom Herbert
On Mon, Mar 28, 2016 at 4:58 PM, Alexander Duyck wrote: > This patch should fix the issues seen with a recent fix to prevent > tunnel-in-tunnel frames from being generated with GRO. The fix itself is > correct for now as long as we do not add any devices that support > NETIF_F_GSO_GRE_CSUM. When

[net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE

2016-03-28 Thread Alexander Duyck
This patch should fix the issues seen with a recent fix to prevent tunnel-in-tunnel frames from being generated with GRO. The fix itself is correct for now as long as we do not add any devices that support NETIF_F_GSO_GRE_CSUM. When such a device is added it could have the potential to mess thing