Re: [net-next v4 1/5] devlink: check flash_update parameter support in net core

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:49 -0700 Jacob Keller wrote: > + if (!(supported_params & > DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT)) { > + NL_SET_ERR_MSG_ATTR(info->extack, nla_component, > + "component update is not > supported");

[net-next v4 1/5] devlink: check flash_update parameter support in net core

2020-09-09 Thread Jacob Keller
When implementing .flash_update, drivers which do not support per-component update are manually checking the component parameter to verify that it is NULL. Without this check, the driver might accept an update request with a component specified even though it will not honor such a request. Instead