Re: [net-next v2 PATCH] devlink: move request_firmware out of driver

2020-11-18 Thread Shannon Nelson
On 11/18/20 10:52 AM, Jacob Keller wrote: On 11/13/2020 3:48 PM, Shannon Nelson wrote: On 11/13/20 2:45 PM, Jacob Keller wrote: -int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name, +int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw,

Re: [net-next v2 PATCH] devlink: move request_firmware out of driver

2020-11-18 Thread Jacob Keller
On 11/13/2020 3:48 PM, Shannon Nelson wrote: > On 11/13/20 2:45 PM, Jacob Keller wrote: >> -int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name, >> +int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw, >>struct netlink_ext_ack *exta

Re: [net-next v2 PATCH] devlink: move request_firmware out of driver

2020-11-13 Thread Shannon Nelson
On 11/13/20 2:45 PM, Jacob Keller wrote: All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_updat

[net-next v2 PATCH] devlink: move request_firmware out of driver

2020-11-13 Thread Jacob Keller
All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_update implementation, perform the request_firmw