Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Andre Guedes
Hi Heiner, Quoting Heiner Kallweit (2020-05-14 15:07:42) > On 14.05.2020 23:31, Jeff Kirsher wrote: > > @@ -4877,8 +4870,7 @@ static int igc_probe(struct pci_dev *pdev, > > > > if (igc_get_flash_presence_i225(hw)) { > > if (hw->nvm.ops.validate(hw) < 0) { > > -

Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 23:31, Jeff Kirsher wrote: > From: Andre Guedes > > In igc_main.c we print log messages using both dev_* and netdev_* > helpers, generating inconsistent output. Since this is a network device > driver, we should preferably use netdev_* helpers because they append > the interface nam

[net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_main.c we print log messages using both dev_* and netdev_* helpers, generating inconsistent output. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out of the log