Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-09 Thread David Ahern
On 2/9/21 4:46 PM, Arjun Roy wrote: > On Tue, Feb 9, 2021 at 8:59 AM Jakub Kicinski wrote: >> >> On Mon, 8 Feb 2021 20:20:29 -0700 David Ahern wrote: >>> On 2/8/21 7:53 PM, Jakub Kicinski wrote: On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: > That would be the case for new userspac

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-09 Thread Leon Romanovsky
On Tue, Feb 09, 2021 at 08:59:38AM -0800, Jakub Kicinski wrote: > On Tue, 9 Feb 2021 08:15:11 +0200 Leon Romanovsky wrote: > > At least in my tree, we have the length check: > > 4155 if (len > sizeof(zc)) { > > 4156 len = sizeof(zc); > > 4157

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-09 Thread Jakub Kicinski
On Mon, 8 Feb 2021 20:20:29 -0700 David Ahern wrote: > On 2/8/21 7:53 PM, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: > >> That would be the case for new userspace on old kernel. Extending the > >> check to the end of the struct would guarantee new userspace can

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 08:15:11 +0200 Leon Romanovsky wrote: > At least in my tree, we have the length check: > 4155 if (len > sizeof(zc)) { > 4156 len = sizeof(zc); > 4157 if (put_user(len, optlen)) > 4158

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 08:20:29PM -0700, David Ahern wrote: > On 2/8/21 7:53 PM, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: > >> On 2/8/21 11:41 AM, Jakub Kicinski wrote: > >>> On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > There is a check that

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 10:41:43AM -0800, Jakub Kicinski wrote: > On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > > On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote: > > > On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: > > > > From: Arjun Roy > > > > > > > > Explicitl

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread David Ahern
On 2/8/21 7:53 PM, Jakub Kicinski wrote: > On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: >> On 2/8/21 11:41 AM, Jakub Kicinski wrote: >>> On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: There is a check that len is not larger than zs and users can't give large buffer. >>

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: > On 2/8/21 11:41 AM, Jakub Kicinski wrote: > > On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > >> There is a check that len is not larger than zs and users can't give > >> large buffer. > >> > >> I would say that is pretty safe to w

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread David Ahern
On 2/8/21 11:41 AM, Jakub Kicinski wrote: > On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: >> On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote: >>> On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: From: Arjun Roy Explicitly define reserved field and requ

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Jakub Kicinski
On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote: > > On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: > > > From: Arjun Roy > > > > > > Explicitly define reserved field and require it to be 0-valued. > > > > > diff

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-07 Thread David Ahern
On 2/7/21 10:49 AM, David Ahern wrote: > On 2/6/21 1:36 PM, Arjun Roy wrote: >> From: Arjun Roy >> >> Explicitly define reserved field and require it to be 0-valued. >> >> Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive >> zerocopy.") >> Signed-off-by: Arjun Roy >> Signed-of

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-07 Thread David Ahern
On 2/6/21 1:36 PM, Arjun Roy wrote: > From: Arjun Roy > > Explicitly define reserved field and require it to be 0-valued. > > Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive > zerocopy.") > Signed-off-by: Arjun Roy > Signed-off-by: Eric Dumazet > Signed-off-by: Soheil Has

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-07 Thread Leon Romanovsky
On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote: > On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: > > From: Arjun Roy > > > > Explicitly define reserved field and require it to be 0-valued. > > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > > index e1a17c6b473c..c8469c579ed8

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: > From: Arjun Roy > > Explicitly define reserved field and require it to be 0-valued. > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index e1a17c6b473c..c8469c579ed8 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -4159,6 +4159,8 @@

[net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread Arjun Roy
From: Arjun Roy Explicitly define reserved field and require it to be 0-valued. Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive zerocopy.") Signed-off-by: Arjun Roy Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh Suggested-by: David Ahern Suggested-by: L