Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread John Fastabend
On 16-02-29 01:25 PM, Cong Wang wrote: > On Mon, Feb 29, 2016 at 10:58 AM, Jiri Pirko wrote: >> Mon, Feb 29, 2016 at 07:40:53PM CET, john.fastab...@gmail.com wrote: >>> On 16-02-27 08:28 PM, Cong Wang wrote: On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend wrote: > On 16-02-26 09:39

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread Cong Wang
On Mon, Feb 29, 2016 at 10:58 AM, Jiri Pirko wrote: > Mon, Feb 29, 2016 at 07:40:53PM CET, john.fastab...@gmail.com wrote: >>On 16-02-27 08:28 PM, Cong Wang wrote: >>> On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend >>> wrote: On 16-02-26 09:39 AM, Cong Wang wrote: > On Fri, Feb 26, 2016

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread Jiri Pirko
Mon, Feb 29, 2016 at 07:40:53PM CET, john.fastab...@gmail.com wrote: >On 16-02-27 08:28 PM, Cong Wang wrote: >> On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend >> wrote: >>> On 16-02-26 09:39 AM, Cong Wang wrote: On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend wrote: > diff --git a/

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread John Fastabend
On 16-02-27 08:28 PM, Cong Wang wrote: > On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend > wrote: >> On 16-02-26 09:39 AM, Cong Wang wrote: >>> On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend >>> wrote: diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 2121df5..e64d20b 10

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-27 Thread Cong Wang
On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend wrote: > On 16-02-26 09:39 AM, Cong Wang wrote: >> On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend >> wrote: >>> diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h >>> index 2121df5..e64d20b 100644 >>> --- a/include/net/pkt_cls.h >>> +++ b/i

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-26 Thread John Fastabend
On 16-02-26 09:39 AM, Cong Wang wrote: > On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend > wrote: >> The offload decision was originally very basic and tied to if the dev >> implemented the appropriate ndo op hook. The next step is to allow >> the user to more flexibly define if any paticular rule

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-26 Thread Cong Wang
On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend wrote: > The offload decision was originally very basic and tied to if the dev > implemented the appropriate ndo op hook. The next step is to allow > the user to more flexibly define if any paticular rule should be > offloaded or not. In order to hav

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-26 Thread Jiri Pirko
Fri, Feb 26, 2016 at 04:53:49PM CET, john.fastab...@gmail.com wrote: >The offload decision was originally very basic and tied to if the dev >implemented the appropriate ndo op hook. The next step is to allow >the user to more flexibly define if any paticular rule should be >offloaded or not. In ord

[net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-26 Thread John Fastabend
The offload decision was originally very basic and tied to if the dev implemented the appropriate ndo op hook. The next step is to allow the user to more flexibly define if any paticular rule should be offloaded or not. In order to have this logic in one function lift the current check into a helpe