Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-10 Thread Alexander Duyck
On 05/10/2016 05:30 AM, Jesper Dangaard Brouer wrote: On Mon, 9 May 2016 13:46:32 -0700 Alexander Duyck wrote: Try testing with TCP_RR instead and watch the CPU utilization. I'm suspecting allocating 8 and freeing 7 buffers for every 1 buffer received will blow any gains right out of the wat

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-10 Thread Eric Dumazet
On Tue, 2016-05-10 at 16:48 +0200, Jesper Dangaard Brouer wrote: > On Tue, 10 May 2016 06:48:54 -0700 > Eric Dumazet wrote: > > > On Tue, 2016-05-10 at 14:30 +0200, Jesper Dangaard Brouer wrote: > > > > > Disable busy poll on both client and server, Not patched: > > > > > > $ netperf -H 198.18

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-10 Thread Jesper Dangaard Brouer
On Tue, 10 May 2016 06:48:54 -0700 Eric Dumazet wrote: > On Tue, 2016-05-10 at 14:30 +0200, Jesper Dangaard Brouer wrote: > > > Disable busy poll on both client and server, Not patched: > > > > $ netperf -H 198.18.40.2 -t TCP_RR -l 60 -T 6,6 -Cc > > MIGRATED TCP REQUEST/RESPONSE TEST from 0.

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-10 Thread Eric Dumazet
On Tue, 2016-05-10 at 14:30 +0200, Jesper Dangaard Brouer wrote: > Disable busy poll on both client and server, Not patched: > > $ netperf -H 198.18.40.2 -t TCP_RR -l 60 -T 6,6 -Cc > MIGRATED TCP REQUEST/RESPONSE TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to > 198.18.40.2 > () port 0 AF_IN

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-10 Thread Jesper Dangaard Brouer
On Mon, 9 May 2016 13:46:32 -0700 Alexander Duyck wrote: > Try testing with TCP_RR instead and watch the CPU utilization. I'm > suspecting allocating 8 and freeing 7 buffers for every 1 buffer > received will blow any gains right out of the water. Also try it with > a mix of traffic. So have

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-10 Thread Jesper Dangaard Brouer
On Mon, 9 May 2016 13:46:32 -0700 Alexander Duyck wrote: > > As you also know, tuning the SLUB system will give higher performance, > > easily. In the future, I'm planning to get some auto-tuning into the > > SLUB allocator. I've already discussed this with Christiph Lameter, at > > MM-summit,

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-09 Thread Alexander Duyck
On Mon, May 9, 2016 at 12:59 PM, Jesper Dangaard Brouer wrote: > On Mon, 9 May 2016 09:20:41 -0700 > Alexander Duyck wrote: > >> On Mon, May 9, 2016 at 6:44 AM, Jesper Dangaard Brouer >> wrote: >> > This patch introduce bulk alloc of SKBs and allow reuse of SKBs >> > free'ed in same softirq cycl

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-09 Thread Jesper Dangaard Brouer
On Mon, 9 May 2016 09:20:41 -0700 Alexander Duyck wrote: > On Mon, May 9, 2016 at 6:44 AM, Jesper Dangaard Brouer > wrote: > > This patch introduce bulk alloc of SKBs and allow reuse of SKBs > > free'ed in same softirq cycle. SKBs are normally free'ed during TX > > completion, but most high spe

Re: [net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-09 Thread Alexander Duyck
On Mon, May 9, 2016 at 6:44 AM, Jesper Dangaard Brouer wrote: > This patch introduce bulk alloc of SKBs and allow reuse of SKBs > free'ed in same softirq cycle. SKBs are normally free'ed during TX > completion, but most high speed drivers also cleanup TX ring during > NAPI RX poll cycle. Thus, i

[net-next PATCH V1 1/3] net: bulk alloc and reuse of SKBs in NAPI context

2016-05-09 Thread Jesper Dangaard Brouer
This patch introduce bulk alloc of SKBs and allow reuse of SKBs free'ed in same softirq cycle. SKBs are normally free'ed during TX completion, but most high speed drivers also cleanup TX ring during NAPI RX poll cycle. Thus, if using napi_consume_skb/__kfree_skb_defer, SKBs will be avail in the n