Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK

2019-02-07 Thread Phil Sutter
On Thu, Feb 07, 2019 at 02:21:56PM +0100, Michal Kubecek wrote: > On Thu, Feb 07, 2019 at 02:02:15PM +0100, Phil Sutter wrote: > > On Thu, Feb 07, 2019 at 01:39:39PM +0100, Michal Kubecek wrote: > > > > > But I still don't think it would be a good idea. It's bad enough that > > > (as I just learne

Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK

2019-02-07 Thread Michal Kubecek
On Thu, Feb 07, 2019 at 02:02:15PM +0100, Phil Sutter wrote: > On Thu, Feb 07, 2019 at 01:39:39PM +0100, Michal Kubecek wrote: > > > But I still don't think it would be a good idea. It's bad enough that > > (as I just learned to my surprise) "ip link del dummy1:0" deletes dummy1 > > without any co

Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK

2019-02-07 Thread Phil Sutter
Hi, On Thu, Feb 07, 2019 at 01:39:39PM +0100, Michal Kubecek wrote: > On Thu, Feb 07, 2019 at 01:27:28PM +0100, Phil Sutter wrote: > > On Thu, Feb 07, 2019 at 11:24:38AM +0100, Phil Sutter wrote: > > > Align interface name handling regarding alias interfaces in > > > rtnl_getlink() with dev_ioctl(

Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK

2019-02-07 Thread Michal Kubecek
On Thu, Feb 07, 2019 at 01:27:28PM +0100, Phil Sutter wrote: > On Thu, Feb 07, 2019 at 11:24:38AM +0100, Phil Sutter wrote: > > Align interface name handling regarding alias interfaces in > > rtnl_getlink() with dev_ioctl() treating SIOCGIFINDEX ioctl calls. The > > latter function strips any colon

Re: [net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK

2019-02-07 Thread Phil Sutter
On Thu, Feb 07, 2019 at 11:24:38AM +0100, Phil Sutter wrote: > Align interface name handling regarding alias interfaces in > rtnl_getlink() with dev_ioctl() treating SIOCGIFINDEX ioctl calls. The > latter function strips any colon suffix before doing the interface > lookup, do the same for RTM_GETL

[net-next PATCH] net: rtnetlink: Support alias interfaces with RTM_GETLINK

2019-02-07 Thread Phil Sutter
Align interface name handling regarding alias interfaces in rtnl_getlink() with dev_ioctl() treating SIOCGIFINDEX ioctl calls. The latter function strips any colon suffix before doing the interface lookup, do the same for RTM_GETLINK requests. Signed-off-by: Phil Sutter --- net/core/rtnetlink.c