Re: [net-next PATCH] net: devmap fix mutex in rcu critical section

2017-08-04 Thread John Fastabend
On 08/04/2017 02:21 PM, John Fastabend wrote: > Originally we used a mutex to protect concurrent devmap update > and delete operations from racing with netdev unregister notifier > callbacks. > [...] > } > @@ -396,22 +385,20 @@ static int dev_map_notification(struct notifier_block > *notifier,

[net-next PATCH] net: devmap fix mutex in rcu critical section

2017-08-04 Thread John Fastabend
Originally we used a mutex to protect concurrent devmap update and delete operations from racing with netdev unregister notifier callbacks. The notifier hook is needed because we increment the netdev ref count when a dev is added to the devmap. This ensures the netdev reference is valid in the dat