Re: [net-next PATCH] e1000: add initial XDP support

2016-09-01 Thread John Fastabend
On 16-08-30 06:31 AM, Jesper Dangaard Brouer wrote: > On Tue, 30 Aug 2016 08:13:15 -0400 Jamal Hadi Salim wrote: > >> On 16-08-29 11:55 AM, Jesper Dangaard Brouer wrote: >>> tc filter add dev mlx5p2 parent : prio 4 protocol ip u32 match ip >>> protocol 17 0xff match udp dst 9 0x flowid 1

Re: [net-next PATCH] e1000: add initial XDP support

2016-09-01 Thread John Fastabend
[...] > I think given how ancient the e1000 is we may see the driver being > a contributing overhead. I believe XDP given location will do > well - but for this kind of driver my gut feeling is probably not > by large margin. > Right so just ran the baseline, xdp, tc spread and its all more or l

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-30 Thread Jesper Dangaard Brouer
On Tue, 30 Aug 2016 08:13:15 -0400 Jamal Hadi Salim wrote: > On 16-08-29 11:55 AM, Jesper Dangaard Brouer wrote: > > tc filter add dev mlx5p2 parent : prio 4 protocol ip u32 match ip > > protocol 17 0xff match udp dst 9 0x flowid 1:1 action > > Syntax is a little more convoluted than

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-30 Thread Jamal Hadi Salim
On 16-08-29 11:55 AM, Jesper Dangaard Brouer wrote: tc filter add dev mlx5p2 parent : prio 4 protocol ip u32 match ip protocol 17 0xff match udp dst 9 0x flowid 1:1 action Syntax is a little more convoluted than that ;->. Try: sudo tc filter add dev eth0 parent : prio 4 protocol

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-29 Thread Jesper Dangaard Brouer
Hi Jamal, I'm adding: drop a specific UDP port option to my script... But I does not match/drop the packets, command below does apply, but it does not work in practice $ ./tc_ingress_drop.sh --verbose --dev mlx5p2 --port 9 tc qdisc del dev mlx5p2 ingress tc qdisc add dev mlx5p2 ingress tc filter

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-29 Thread Jesper Dangaard Brouer
On Mon, 29 Aug 2016 06:53:53 -0400 Jamal Hadi Salim wrote: > On 16-08-29 04:30 AM, Jesper Dangaard Brouer wrote: > > > Hi Jamal, > > > > Can you please provide a simple "tc" command that implements "tc drop"? > > > > Then, I'll add this to the series of tests I'm using for (what I call) > > "zoo

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-29 Thread Jamal Hadi Salim
On 16-08-29 04:30 AM, Jesper Dangaard Brouer wrote: Hi Jamal, Can you please provide a simple "tc" command that implements "tc drop"? Then, I'll add this to the series of tests I'm using for (what I call) "zoom-in" benchmarking. Thanks Jesper. Something simple since this is done in ingress

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-29 Thread Jesper Dangaard Brouer
On Sun, 28 Aug 2016 08:23:26 -0400 Jamal Hadi Salim wrote: > On 16-08-27 03:11 AM, John Fastabend wrote: > > From: Alexei Starovoitov > > > > This patch adds initial support for XDP on e1000 driver. Note e1000 > > driver does not support page recycling in general which could be > > added as a fu

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-28 Thread John Fastabend
On 16-08-28 08:56 AM, William Tu wrote: > Hi, > > Reading through the patch, I found some minor typos below. > > On Sat, Aug 27, 2016 at 12:11 AM, John Fastabend > wrote: >> From: Alexei Starovoitov >> >> This patch adds initial support for XDP on e1000 driver. Note e1000 >> driver does not sup

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-28 Thread John Fastabend
On 16-08-27 10:55 PM, Or Gerlitz wrote: > On Sat, Aug 27, 2016 at 10:11 AM, John Fastabend > wrote: >> From: Alexei Starovoitov > >> This patch adds initial support for XDP on e1000 driver. Note e1000 >> driver does not support page recycling in general which could be >> added as a further impro

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-28 Thread William Tu
Hi, Reading through the patch, I found some minor typos below. On Sat, Aug 27, 2016 at 12:11 AM, John Fastabend wrote: > From: Alexei Starovoitov > > This patch adds initial support for XDP on e1000 driver. Note e1000 > driver does not support page recycling in general which could be > added as

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-28 Thread Jamal Hadi Salim
On 16-08-27 03:11 AM, John Fastabend wrote: From: Alexei Starovoitov This patch adds initial support for XDP on e1000 driver. Note e1000 driver does not support page recycling in general which could be added as a further improvement. However for XDP_DROP and XDP_XMIT the xdp code paths will rec

Re: [net-next PATCH] e1000: add initial XDP support

2016-08-27 Thread Or Gerlitz
On Sat, Aug 27, 2016 at 10:11 AM, John Fastabend wrote: > From: Alexei Starovoitov > This patch adds initial support for XDP on e1000 driver. Note e1000 > driver does not support page recycling in general which could be > added as a further improvement. However for XDP_DROP and XDP_XMIT > the xd

[net-next PATCH] e1000: add initial XDP support

2016-08-27 Thread John Fastabend
From: Alexei Starovoitov This patch adds initial support for XDP on e1000 driver. Note e1000 driver does not support page recycling in general which could be added as a further improvement. However for XDP_DROP and XDP_XMIT the xdp code paths will recycle pages. This patch includes the rcu_read_